FileUpload options for Server Config#6997
Closed
dblythy wants to merge 17 commits intoparse-community:masterfrom
Closed
FileUpload options for Server Config#6997dblythy wants to merge 17 commits intoparse-community:masterfrom
dblythy wants to merge 17 commits intoparse-community:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6997 +/- ##
==========================================
- Coverage 93.83% 93.82% -0.02%
==========================================
Files 169 169
Lines 12402 12415 +13
==========================================
+ Hits 11638 11648 +10
- Misses 764 767 +3
Continue to review full report at Codecov.
|
mtrezza
requested changes
Nov 8, 2020
mtrezza
requested changes
Nov 9, 2020
mtrezza
requested changes
Nov 9, 2020
Member
|
What are the open points in this PR? |
Member
Author
|
I’ve got to resolve conflicts and fix failing tests, sorry. |
Snyk has created this PR to upgrade pg-promise from 10.6.2 to 10.7.0. See this package in npm: https://www.npmjs.com/package/pg-promise See this project in Snyk: https://app.snyk.io/org/acinader/project/8c1a9edb-c8f5-4dc1-b221-4d6030a323eb?utm_source=github&utm_medium=upgrade-pr
* Update PostgresStorageAdapter.js Start moving toward better, ES7 syntax. * Update PostgresStorageAdapter.js Fixing spaces 🤦♂️
* Update PostgresStorageAdapter.js Improve `createClass` transaction: * `await` makes it a more consistent sequence of queries * `batch` is not needed there * No need for an extra `.then` section * Update PostgresStorageAdapter.js Remove batch-dependent error code check, as it should happen automatically without batch result. * Update PostgresStorageAdapter.js Removing unused variable.
…-community#6990) * Add `cloud` parameter to Docker command (parse-community#6988) * Add note to run Image with Cloud Code feature.
937062c to
652d874
Compare
This reverts commit 076ef26.
Member
Author
|
I accidentally rebased from my branch which I use on my AWS servers and i'm not overly experienced with git, so I just created a new branch with the changes. Sorry!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #6995, this PR allows the following options for parse server:
(thank you @mtrezza for the copy + paste)
This is a breaking change as by default, public file uploads will be rejected.
Properly closes #2137, and in relation to our discussion on the community forum.