GitHub actions

[davimacedo]

No description provided.

[Moumouls]

you're right. I will go to the 18.04

I saw that you were fooled by the version selector like me!

[davimacedo]

Yes.

Tests for 4.4.2 failed. Maybe we should address this issue on a separate pr. I will downgrade to 4.0.21.

[davimacedo]

Now we just need to pray for the flaky tests do not fail :)

[Moumouls]

@davimacedo mongo version is correct i think, npm run lint seems to cancel the workflow don't know why

[davimacedo]

No.. error still in mongodb-runner:
https://github.com/parse-community/parse-server/pull/7035/checks?check_run_id=1491533641

[davimacedo]

I will revert back to ubuntu 16

[Moumouls]

I didn't know that a failure in the matrix could cause the other matrix to crash.

[Moumouls]

@davimacedo it's not a problem with ubuntu it's the Node Version, mongodb runner is not usable under Node14/15

[davimacedo]

By default, they cancel the other jobs within the same matrix but there is an option that you change this behavior. I think it is better to actually cancel though, right?

[Moumouls]

pull request was sent but new package version not released yet: mongodb-js/runner#174

[davimacedo]

Makes sense.

[davimacedo]

In this case I will go back to 18.04 and remove the newest node. We put it back once mongodb supports it. ok?

[Moumouls]

[davimacedo]

finally passed through mongodb-runner

[davimacedo]

I think we are good now. Maybe wait to see if @dplewis has any additional thoughts and merge?

[Moumouls]

Finally the CI

[Moumouls]

@davimacedo is it possible the reduce the codecov threshold ?

[davimacedo]

It looks it is possible: https://docs.codecov.io/docs/commit-status

[dplewis]

LGTM!

[mtrezza]

@dplewis I took a quick look at this because you mentioned it; looking into the CI logs I see some misconfigs like different MongoDB versions in pretest vs. test, also MongoDB >=4.2 is not compatible with MMAPv1 storage engine, mongo-runner will simply fail to start. Anyway, tests pass now for all recent MongoDB versions in #7161.

[mtrezza]

@davimacedo just wondering, what is COVERAGE_OPTION used for? I haven't found any references.

Edit: Found a ref, I think that can be removed, maybe from travis ci?

[davimacedo]

I believe it makes this to work.

[mtrezza]

How so?

I believe it was part of a script in package.json, that has been removed:

cross-env NODE_ENV=test TESTING=1 ./node_modules/.bin/babel-node $COVERAGE_OPTION ./node_modules/jasmine/bin/jasmine.js

[davimacedo]

You might be right. Let's try to remove it and see what happens.