FileSystemAdapter for saving files to the server's file system

[dtsolis]

Can be used while starting the parse-server

var api = new ParseServer({
  databaseURI: 'mongodb://localhost:52853/dev',
  appId: 'appId',
  masterKey: "masterKey",
  serverURL: "http://localhost:1337/parse",
  filesAdapter: new FileSystemAdapter({
    filesSubDirectory: 'path/under/files/directory'
  })
});

[flovilmart]

remove '/'

[dtsolis]

Without '/' git ignores 'src/Adapters/Files/' folder too. I added this so git ignores only the first-level 'files' folder

[flovilmart]

Thanks for the PR!

Please consider adding the according tests.

[facebook-github-bot]

@dtsolis updated the pull request.

[dtsolis]

Thanks for your comments! I updated the adapter. Also, regarding tests, since I am not that experienced writing tests for node it could take a while.

[kilabyte]

Is there any special setup needed to the server for this? Or does the adapter just save the file to the specified directory?

[dtsolis]

It just saves the file to the specified directory. This directory will be created under a 'files' folder. So, even if you want to have more than one app under the same directory, the file structure could be the following:

| - files/
| | - subDirForApp1/
| | - subDirForApp2/
| - indexForApp1.js
| - indexForApp2.js

[codecov-io]

Current coverage is 90.73%

Merging #716 into master will decrease coverage by -0.89% as of cab1474

@@            master    #716   diff @@
======================================
  Files           73      74     +1
  Stmts         4432    4489    +57
  Branches       888     899    +11
  Methods          0       0       
======================================
+ Hit           4061    4073    +12
  Partial         10      10       
- Missed         361     406    +45

Review entire Coverage Diff as of cab1474

Powered by Codecov. Updated on successful CI builds.

[dtsolis]

@flovilmart Ok, so.. Not sure if i should but i did a rebase to update my branch with the latest changes on master, in order to fix some conflicts. I also i added the test on the FilesController.spec.js.

[flovilmart]

All those commits don't seem right... You did not rebase your branch properly.

you need to cleanup you rebase

• run git reflog // this will show you the history of all the git commands
• identify when the rebase started: it should look like that: 2c991a4 HEAD@{25}: rebase: checkout master
• do git checkout HEAD@{25} // replace 25 by the value you see
• create a new branch: git checkout -b dstolis.fsadapter-proper
• go on master: git checkout master
• update: git pull origin master
• go back to your new branch: git checkout -b dstolis.fsadapter-proper
• run: git rebase master

if a conflict is detected, rebase will stop, and let you amend the commit/fix the conflict

• for each conflicted file, git add file/myfile.js
• once all the conflicts are resolved for the commit, run git rebase --continue

Hope that helps

[facebook-github-bot]

@dtsolis updated the pull request.

[flovilmart]

@dtsolis still not good at all

[dtsolis]

@flovilmart i think now it's better

[flovilmart]

please support windows too with separator

[facebook-github-bot]

@dtsolis updated the pull request.

[gfosco]

Still have 12 commits here. Try updating the latest master, making a new branch, and bringing the changes in again. Close this one, then use https://github.com/ParsePlatform/parse-server/pull/716/files as a reference, and open a new PR with just 1 commit.

[flovilmart]

please revert those changes