Add check for property

[jdposthuma]

New Pull Request Checklist

• I am not disclosing a vulnerability.
• I am creating this PR in reference to an issue.

Issue Description

This PR fixes the open issue.

Related issue: #7416

Approach

Simply added a truthy check

TODOs before merging

• Add test cases
• Add entry to changelog

[dplewis]

@jdposthuma Thanks for the contribution. Can you go though the ToDo list? Add a test case, update the change log, etc?

[jdposthuma]

@jdposthuma Thanks for the contribution. Can you go though the ToDo list? Add a test case, update the change log, etc?

@dplewis - Done. I've added to the changelog.

None of the other items seemed valid:

• Add test cases

I haven't been able to capture (or simulate) the failing class

• Add changes to documentation (guides, repository pages, in-code descriptions)

Too insignificant to add to docs

• Add security check

Doesn't change security

• Add new Parse Error codes to Parse JS SDK

No new parse error code

[mtrezza]

Except for the test case, you can delete the non-applicable TODOs from the list.

The change makes sense, even if there wasn't a reported issue, just for code quality. However, it would be good to have a test case, to make your fix sustainable and prevent a future change from reverting your fix by mistake. And to verify that it solved the issue. Maybe you can give it another try?

I classified this as bug of low severity due to the missing test case verification.

[codecov]

Codecov Report

Merging #7421 (213e98e) into master (129f7bf) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 213e98e differs from pull request most recent head 94d387f. Consider uploading reports for the commit 94d387f to get more accurate results

@@            Coverage Diff             @@
##           master    #7421      +/-   ##
==========================================
- Coverage   93.92%   93.92%   -0.01%     
==========================================
  Files         181      181              
  Lines       13245    13247       +2     
==========================================
+ Hits        12441    12442       +1     
- Misses        804      805       +1     

Impacted Files	Coverage Δ
src/LiveQuery/QueryTools.js	94.73% <100.00%> (+0.05%)	⬆️
src/batch.js	91.37% <0.00%> (-1.73%)	⬇️
src/Adapters/Files/GridFSBucketAdapter.js	79.50% <0.00%> (-0.82%)	⬇️
src/RestWrite.js	93.76% <0.00%> (-0.16%)	⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js	93.02% <0.00%> (+0.43%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 129f7bf...94d387f. Read the comment docs.

[mtrezza]

@jdposthuma Can you please rebase on master?

[jdposthuma]

@jdposthuma Can you please rebase on master?

Done

[jdposthuma]

@mtrezza - Test case added.

I'm really glad you pushed for it because my original fix had a logic problem. 🙏

[jdposthuma]

Hi @mtrezza - do I need to do anything else to get this to merge?

[mtrezza]

Just the changelog entry

[mtrezza]

Looks good to me, thanks for this PR!

[davimacedo]

LGTM!

[jdposthuma]

Thanks guys! When's the next release planned?

[mtrezza]

See #7271 (comment)

[parseplatformorg]

🎉 This change has been released in version 5.0.0-beta.1

[parseplatformorg]

🎉 This change has been released in version 5.0.0