You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Use GitHub Actions to push to Docker hub during merges of PRs and releases. Merges to the master branch push the latest image to latest on Docker Hub and releases push the latest release with the same tag name. You can see the tags this creates using my research repo: https://hub.docker.com/repository/docker/netreconlab/parse-dashboard
This builds images for multiple architectures as oppose to just Intel. Builds for all of same architectures as it’s dependency image, node:lts-alpine except for linux/ppc64le and linux/s390x as those both currently fail.
A side-effect is it creates another tag on docker-hub called master, which I guess could be useful if something else is pushed after latest
If you want to add docker images for missing versions on docker hub (4.5.2 - 4.10.3), cherry pick this commit, place it in the respective release branch, and in docker-publish.yml change latest=true to latest=false, then re-run the action that released each version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
Issue Description
Related issue: #7547
Approach
Use GitHub Actions to push to Docker hub during merges of PRs and releases. Merges to the master branch push the latest image to
lateston Docker Hub and releases push the latest release with the same tag name. You can see the tags this creates using my research repo: https://hub.docker.com/repository/docker/netreconlab/parse-dashboardThis builds images for multiple architectures as oppose to just Intel. Builds for all of same architectures as it’s dependency image, node:lts-alpine except for
linux/ppc64leandlinux/s390xas those both currently fail.A side-effect is it creates another tag on docker-hub called
master, which I guess could be useful if something else is pushed afterlatestTODOs before merging