add cache-control and expires options

[tombokombo]

Hello, this PR add support for setting cache-control and expires header to s3 object, same as aws cli

s5cmd cp --acl "public-read" --expires "2024-10-01T20:30:00Z" --cache-control "public, max-age=345600, s-maxage=345600" foobar
  s3://example-bucket/foobar

[tombokombo]

@aykutfarsak @ilkinulas guys could you please review, thanks.

[ilkinulas]

@aykutfarsak @ilkinulas guys could you please review, thanks.

@tombokombo there has been a lot of development in s5cmd these days, this PR is waiting in the queue, I will take a look at it soon.

[aykutfarsak]

With invalid expires date value, aws cli returns an error:

➜  aws s3 cp file s3://bucket/prefix --expires "2024-13-01T20:30:00Z"
upload failed: ./Makefile to s3://bucket/prefix/file Parameter validation failed:
Invalid type for parameter Expires, value: 2024-13-01T20:30:00Z, type: <class 'str'>, valid types: <class 'datetime.datetime'>, timestamp-string
➜  echo $?
1

So I am not sure if we should ignore the invalid expire date error. Maybe we can increase the log level to error or return the error immediately.

What do you think @ilkinulas?

[ilkinulas]

With invalid expires date value, aws cli returns an error:

➜  aws s3 cp file s3://bucket/prefix --expires "2024-13-01T20:30:00Z"
upload failed: ./Makefile to s3://bucket/prefix/file Parameter validation failed:
Invalid type for parameter Expires, value: 2024-13-01T20:30:00Z, type: <class 'str'>, valid types: <class 'datetime.datetime'>, timestamp-string
➜  echo $?
1

So I am not sure if we should ignore the invalid expire date error. Maybe we can increase the log level to error or return the error immediately.

What do you think @ilkinulas?

Good catch @aykutfarsak 👍 Let's add a validation for --expires parameter

[tombokombo]

With invalid expires date value, aws cli returns an error:

➜  aws s3 cp file s3://bucket/prefix --expires "2024-13-01T20:30:00Z"
upload failed: ./Makefile to s3://bucket/prefix/file Parameter validation failed:
Invalid type for parameter Expires, value: 2024-13-01T20:30:00Z, type: <class 'str'>, valid types: <class 'datetime.datetime'>, timestamp-string
➜  echo $?
1

So I am not sure if we should ignore the invalid expire date error. Maybe we can increase the log level to error or return the error immediately.
What do you think @ilkinulas?

Good catch @aykutfarsak Let's add a validation for --expires parameter

Actually, date string validation is already in place, I just choose to print debug message in case of invalid date, so maybe log.Error instead of log.Debug would by enough?

[ilkinulas]

I was trying invalid time formats to see s3 behavior, here are my findings:

• if we upload a new object s3 ignores invalid Expires metadata.
• if we override an existing s3 objects (which has a valid Expires metadata) with an invalid expires value, s3 deletes the current object's Expires metadata.

So, it would be better to return the error and do not cp/mv any objects in case of unparsable --expires values.

[tombokombo]

ok, done

[ilkinulas]

@tombokombo thank you for the contribution.