Skip to content

command: return non-zero exit code for errors and add ignore-glacier-warnings option#404

Merged
sonmezonur merged 8 commits intomasterfrom
non_zero_exit_code_for_errors
Feb 20, 2022
Merged

command: return non-zero exit code for errors and add ignore-glacier-warnings option#404
sonmezonur merged 8 commits intomasterfrom
non_zero_exit_code_for_errors

Conversation

@sonmezonur
Copy link
Member

@sonmezonur sonmezonur commented Feb 2, 2022

Fixes #304, fixes #346 (which are release-blockers for v2.0.0)

@sonmezonur sonmezonur requested a review from a team as a code owner February 2, 2022 10:47
@sonmezonur sonmezonur requested review from igungor and ilkinulas and removed request for a team February 2, 2022 10:47
@igungor
Copy link
Member

igungor commented Feb 3, 2022

Fixes #304 and #346 (which are release-blockers for v2.0.0)

Could you adjust the PR description according to https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword.

sonmezonur and others added 3 commits February 3, 2022 18:32
Co-authored-by: H. İbrahim Güngör <igungor@gmail.com>
Co-authored-by: H. İbrahim Güngör <igungor@gmail.com>
@sonmezonur
Copy link
Member Author

Fixes #304 and #346 (which are release-blockers for v2.0.0)

Could you adjust the PR description according to https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword.

done

@sonmezonur
Copy link
Member Author

@ilkinulas PTAL

@sonmezonur sonmezonur merged commit 234874b into master Feb 20, 2022
@sonmezonur sonmezonur deleted the non_zero_exit_code_for_errors branch February 20, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ignore Glacier warnings Some errors do not result in a non-zero exit code

3 participants