storage/s3: add SlowDown as retryable#507
Merged
igungor merged 1 commit intopeak:masterfrom Sep 2, 2022
Merged
Conversation
in v0.7.0, SlowDown was a retryable error. https://github.com/peak/s5cmd/blob/v0.7.0/core/error.go#L49 Add that again as retryable because with peak#506, one might get slowdown errors while testing with other endpoint urls.
boraberke
requested review from
aykutfarsak and
sonmezonur
and removed request for
a team
igungor
approved these changes
Sep 2, 2022
seruman
approved these changes
Sep 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in v0.7.0, SlowDown was a retryable error.
Add that again as retryable because with #506, one might get slowdown errors while testing with other endpoint urls.