Merged
Conversation
matan129
requested review from
denizsurmeli and
ilkinulas
and removed request for
a team
matan129
changed the title
sso_session setup aws-sdk-go@1.44.298sso_session setup
|
Just ran into this myself. Please review and cut this into a new release. |
Contributor
Author
|
Hi @igungor, can we get this merged? Thanks 🙏 |
|
Is there any update to this PR? Really looking forward to supporting S3 Express! |
Contributor
Author
|
Hi @ahmethakanbesel, any change for getting it merged? |
ahmethakanbesel
approved these changes
Jun 13, 2024
Contributor
|
Closes #726. |
Contributor
|
Hi, thanks for your contribution. Can you please follow the style guide in the PR title, since the title will be the commit message in the master branch. |
Contributor
Author
|
Done |
Contributor
|
Hi, with the following go build: When run The following diff occurs. diff --git a/go.sum b/go.sum
index cf4b72f..53f6cf4 100644
--- a/go.sum
+++ b/go.sum
@@ -1,6 +1,5 @@
github.com/VividCortex/ewma v1.2.0 h1:f58SaIzcDXrSy3kWaHNvuJgJ3Nmz59Zji6XoJR/q1ow=
github.com/VividCortex/ewma v1.2.0/go.mod h1:nz4BbCtbLyFDeC9SUHbtcT5644juEuWfUAUnGx7j5l4=
-github.com/aws/aws-sdk-go v1.44.256 h1:O8VH+bJqgLDguqkH/xQBFz5o/YheeZqgcOYIgsTVWY4=
github.com/aws/aws-sdk-go v1.44.256/go.mod h1:aVsgQcEevwlmQ7qHE9I3h+dtQgpqhFB+i8Phjh7fkwI=
github.com/aws/aws-sdk-go v1.44.298 h1:5qTxdubgV7PptZJmp/2qDwD2JL187ePL7VOxsSh1i3g=
github.com/aws/aws-sdk-go v1.44.298/go.mod h1:aVsgQcEevwlmQ7qHE9I3h+dtQgpqhFB+i8Phjh7fkwI=The same diff occurs with |
matan129
force-pushed
the
feature/update-aws-sdk-to-support-sso-session
branch
from
61d53cf to
162524c
Compare
Contributor
Author
|
Fixed |
matan129
force-pushed
the
feature/update-aws-sdk-to-support-sso-session
branch
from
162524c to
911be65
Compare
ahmethakanbesel
approved these changes
Jul 3, 2024
denizsurmeli
approved these changes
Jul 3, 2024
ilkinulas
approved these changes
Jul 4, 2024
denizsurmeli
added a commit
that referenced
this pull request
Jul 4, 2024
#684 shows that if the vendor and the vendor generated by the tidy&vendor pipeline has diffs, we don't fail in the CI, but we should. This PR adds the check to the Makefile. --------- Co-authored-by: Deniz Surmeli <denizsurmeli@peak.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this is a simple change - I have a setup with AWS SSO, specifically
sso_session(docs).It got implemented in the AWS Go SDK fairly recently aws/aws-sdk-go#4885 - v1.44.298
Since it's just a patch version upgrade, it was just a simple matter of bumping the version.
Thanks