Merged
Conversation
Contributor
|
this can now be rebased and made ready for merging ;-) |
aa724f0 to
353e66c
Compare
Member
Author
|
It should be good now. However this plugin may still need a warning, as we have a call to the sleep function inside which is synchronous, there is the possibility to have asynchronous sleep but it heavily depends on the implementation (amp / react / ...), so there is no possibility to add it here |
Contributor
do you want to add something for this topic to the documentation of the retry plugin? |
Member
Author
|
Done in php-http/documentation#237 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this PR?
It adds a deferred class which allow to resolve retry in an async way (no more wait call)
Why?
Previously using retry plugin would force async to be sync
Checklist