[skip ci] Mark test as XFAIL due to LSAN bug on Clang 14#12018
[skip ci] Mark test as XFAIL due to LSAN bug on Clang 14#12018Girgias merged 4 commits intophp:masterfrom
Conversation
sapi/cli/tests/ext_loading.phpt
Outdated
| } | ||
| ?> | ||
| --XFAIL-- | ||
| LSAN bug on Clang 14 marks this as leaking |
There was a problem hiding this comment.
Please move this to skipif and only xfail if we're actually using asan.
sapi/cli/tests/ext_loading.phpt
Outdated
| } | ||
| ?> | ||
| --SKIPIF-- | ||
| <?php if (getenv('SKIP_ASAN')) die('xfail LSAN bug on Clang 14 marks this as leaking'); ?> |
There was a problem hiding this comment.
Oh, and also, it doesn't report a leak, it crashes.
There was a problem hiding this comment.
Oh, and also use xleak please 😄 Sorry for the fragmented comments.
There was a problem hiding this comment.
Right, also we have trailing whitespaces in the test output so... changed that too
Change formatting of output to not have trailing whitespaces
iluuu1994
left a comment
iluuu1994
left a comment
There was a problem hiding this comment.
Looks good if tests pass. It would be nice if LSan wasn't crashing, but I don't have a solution...
Yeah that would be ideal :[ |
|
Can be reverted in #12034 😄 (or the skipif removed rather) |
This is due to apparently some combination of glibc and Clang 14 which we are unfortunately hitting
This is due to apparently some combination of glibc and Clang 14 which we are unfortunately hitting
2 participants
No description provided.