Fix MQTT discovery for buttons (now binary sensors with separate MQTT topics)#209
Merged
o0shojo0o merged 7 commits intopixelit-project:mainfrom Sep 14, 2022
pplucky:main
Merged
Fix MQTT discovery for buttons (now binary sensors with separate MQTT topics)#209o0shojo0o merged 7 commits intopixelit-project:mainfrom pplucky:main
o0shojo0o merged 7 commits intopixelit-project:mainfrom
pplucky:main
Conversation
Fix MQTT discovery for button presses
pplucky
changed the title
o0shojo0o
approved these changes
Sep 14, 2022
Member
|
forgotten, thank you for your support at this point! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix MQTT discovery for buttons and change entity names for buttons, from Button0/1/2 to Left/Middle/Right Button.
Fixes #199.
Also changed the MQTT Discovery button entities from sensors to binary_sensors (with icon). This is a breaking change that causes the old non-working sensors to be kept and new working binary sensors to also appear. Removing the PixelIt device from MQTT Discovery integration should do the trick, as it will appear again automatically with only thee correct sensors..
Also allowed all button actions to co-exist (using different MQTT topic for each button).