Decouple Excpect from PHPUnit / maintain compatibility#57
Merged
smnandre merged 2 commits intoplaywright-php:mainfrom Dec 20, 2025
Merged
Decouple Excpect from PHPUnit / maintain compatibility#57smnandre merged 2 commits intoplaywright-php:mainfrom
smnandre merged 2 commits intoplaywright-php:mainfrom
Conversation
-> use AssertionException instead of AssertionFailedError
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introducing a custom
AssertionExceptionand a newExpectDecoratorclass to decouple from and still be compatible with PHPUnit.Assertion Counting Integration:
PHPUnit\Framework\AssertionFailedErrorwithPlaywright\Assertions\Failure\AssertionExceptioninExpectation.phpandExpect.phpExpectDecoratorclass that wraps theExpectclass and automatically increments PHPUnit assertion count when availableexpect()method inPlaywrightTestCaseTraitto return an instance ofExpectDecoratorinstead ofExpect