BugFix: Skip validating and parsing comment lines early (#1108)#1109
Merged
csmarchbanks merged 1 commit intoprometheus:masterfrom May 28, 2025
Conversation
wissamir
force-pushed
the
bug_fix_skip_comment_lines_earlier_and_donot_parse
branch
from
f359dbd to
12c055a
Compare
Contributor
Author
|
@csmarchbanks please mind reviewing this |
wissamir
changed the title
Member
There was a problem hiding this comment.
Thank you for both the report and the fix! This looks reasonable to me, but I think the else can be removed from line 347 of your branch and the comment describing that this ignores other comment tokens would be nice to move up here.
You will need to sign the DCO as well before I can merge.
wissamir
force-pushed
the
bug_fix_skip_comment_lines_earlier_and_donot_parse
branch
from
12c055a to
fed9be0
Compare
Contributor
Author
|
Yep, that All sorted out |
Contributor
Author
|
Thanks for merging |
Member
|
The next couple of days. I am looking into a couple other issues (namely the change in how licensing looks) to see if I want to include those in a patch release as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1108