Skip to content

Fix PyInstaller support#533

Merged
akx merged 2 commits intopython-babel:masterfrom
yagebu:fix-pyinstaller
Jan 15, 2018
Merged

Fix PyInstaller support#533
akx merged 2 commits intopython-babel:masterfrom
yagebu:fix-pyinstaller

Conversation

@yagebu
Copy link
Contributor

@yagebu yagebu commented Sep 28, 2017

PyInstaller+Babel was supported for quite a while before 2.5.0 - which broke support for this configuration by default. PyInstaller actually synthesizes a __file__ for frozen aka bundled code that makes this "just work".

Closes #529.

@codecov-io
Copy link

Codecov Report

Merging #533 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #533      +/-   ##
==========================================
- Coverage      90%   89.99%   -0.02%     
==========================================
  Files          24       24              
  Lines        4024     4018       -6     
==========================================
- Hits         3622     3616       -6     
  Misses        402      402
Impacted Files Coverage Δ
babel/core.py 95.51% <100%> (ø) ⬆️
babel/localedata.py 95.45% <100%> (-0.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f29eccd...29da2d2. Read the comment docs.

@yagebu
Copy link
Contributor Author

yagebu commented Jan 12, 2018

Pinging @akx: Is anything blocking this from getting merged?

@akx
Copy link
Member

akx commented Jan 15, 2018

Hi @yagebu – I'm so sorry I dropped the ball on this one! Merging now and releasing 2.5.2 thereafter.

@akx akx merged commit 7f4a956 into python-babel:master Jan 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants