gh-102388: Add windows_31j to aliases for cp932 codec#102389
Merged
methane merged 2 commits intopython:mainfrom Feb 19, 2024
Merged
gh-102388: Add windows_31j to aliases for cp932 codec#102389methane merged 2 commits intopython:mainfrom
methane merged 2 commits intopython:mainfrom
Conversation
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
|
All commit authors signed the Contributor License Agreement. |
moriyama
force-pushed
the
fix-issue-102388
branch
from
c1d58ef to
e237198
Compare
malemburg
approved these changes
Feb 16, 2024
Member
malemburg
left a comment
malemburg
left a comment
There was a problem hiding this comment.
LGTM.
Perhaps you could fix the many "py:class reference target not found: Codec" errors as part of this PR as well. I'm not really sure what's causing them - not a ResT expert.
methane
reviewed
Feb 17, 2024
moriyama
force-pushed
the
fix-issue-102388
branch
from
e237198 to
566d1e0
Compare
The charset name "Windows-31J" is registered in the IANA Charset Registry[1] and is implemented in Python as the cp932 codec. This commit adds windows_31j to the aliases of cp932. [1] https://www.iana.org/assignments/charset-reg/windows-31J Signed-off-by: Masayuki Moriyama <masayuki.moriyama@miraclelinux.com>
moriyama
force-pushed
the
fix-issue-102388
branch
from
566d1e0 to
93e2921
Compare
Member
There is no |
Contributor
Author
|
Thank you for reviewing and merging. |
woodruffw
pushed a commit
to woodruffw-forks/cpython
that referenced
this pull request
Mar 4, 2024
…02389) The charset name "Windows-31J" is registered in the IANA Charset Registry[1] and is implemented in Python as the cp932 codec. [1] https://www.iana.org/assignments/charset-reg/windows-31J Signed-off-by: Masayuki Moriyama <masayuki.moriyama@miraclelinux.com>
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
…02389) The charset name "Windows-31J" is registered in the IANA Charset Registry[1] and is implemented in Python as the cp932 codec. [1] https://www.iana.org/assignments/charset-reg/windows-31J Signed-off-by: Masayuki Moriyama <masayuki.moriyama@miraclelinux.com>
LukasWoodtli
pushed a commit
to LukasWoodtli/cpython
that referenced
this pull request
Jan 22, 2025
…02389) The charset name "Windows-31J" is registered in the IANA Charset Registry[1] and is implemented in Python as the cp932 codec. [1] https://www.iana.org/assignments/charset-reg/windows-31J Signed-off-by: Masayuki Moriyama <masayuki.moriyama@miraclelinux.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The charset name "Windows-31J" is registered in the IANA Charset Registry[1] and is implemented in Python as the cp932 codec.
This commit adds windows_31j to the aliases of cp932.
[1] https://www.iana.org/assignments/charset-reg/windows-31J