Clean-up typing_extensions -- typing_extensions

[AA-Turner]

xref #892
@srittau

Actual typing_extensions PR. Unchanged from original.

A

[srittau]

Thanks!

You (sensibly) removed a few non-underscored, but also not exported via __all__ attributes. As this is technically an API change (even though it's not exported via __all__), could you add these removals to typing_extensions/CHANGELOG:

• TypingMeta
• OLD_GENERICS
• SUBS_TREE
• HAVE_ANNOTATED
• HAVE_PROTOCOLS

Also could you mention in the Changelog that starting with 4.0.0 support for Python 2 and <3.6 has been dropped?

A few more remarks below.

[AA-Turner]

Sorry, forgot to add a changelog entry earlier -- have now done so.

[srittau]

Thanks again. For future reference: Please don't force push as it makes it harder to review changes.

[AA-Turner]

Sorry - I had to rebase onto master to pick up the changelog -- is it better to merge in HEAD instead of rebase + force push?
A

[srittau]

Yes, we squash merge anyway, so rebasing should not be necessary.