Merged
Conversation
Also in this commit is forcing using file-loader on icons as currently we're inlining them which is wasteful as most aren't used nor are they latency sensative.
vcarl
approved these changes
Jan 25, 2017
Member
vcarl
left a comment
vcarl
left a comment
There was a problem hiding this comment.
Nice, I hate font pop in and it's noticeably better on this PR than on the site. Great work.
Contributor
Author
|
Sweet, merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Been working on a little side project to push google fonts to npm to make it really easy to self-host fonts. This makes for a nice little speed index boost as it avoids the extra ssl negotiation to google fonts + the extra round trip to first grab their css file and then download the fonts. Instead the fontface css is embedded directly in the
<head>.I also used the new link preload fetch directive (only supported on chrome atm) which instructs the browser to immediately start downloading the font file (normally browsers wait to see if the font is actually used in the html on the page before downloading).
Speed index savings seem around ~300 milliseconds on desktop/cable & ~1.5 seconds on smartphone/3g.
I also switched the various icons to use file-loader vs. the default url-loader as currently we're base64 encoding icons in the HTML which is wasted bytes.
desktop/cable:
before: http://www.webpagetest.org/result/170125_GR_GDCE/
after: http://www.webpagetest.org/result/170125_VD_GFA5/
smartphone/3g:
before: http://www.webpagetest.org/result/170125_9G_GDC0/
after: http://www.webpagetest.org/result/170125_1A_GFA0/
desktop/3g:
before: http://www.webpagetest.org/result/170125_TZ_GEJ7/
after: http://www.webpagetest.org/result/170125_21_GF9S/