Skip to content

Conversation

@rhiroyuki
Copy link
Contributor

This PR adds the pt-BR translation for Styling and CSS.

Partially solves: #1

@rhiroyuki rhiroyuki changed the title Add pt-BR faq-styling translation Translate Styling and CSS to pt-BR Feb 9, 2019
@fjoshuajr fjoshuajr added the needs review A pull request ready to be reviewed label Feb 9, 2019
Copy link
Member

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @rhiroyuki! left a nit, otherwise nice work!

@cezaraugusto cezaraugusto added needs author response Changes requested needing author's input and removed needs review A pull request ready to be reviewed labels Feb 9, 2019
Co-Authored-By: rhiroyuki <rhiroyuki@users.noreply.github.com>
@rhiroyuki
Copy link
Contributor Author

I've committed your suggestion, @cezaraugusto. Thank you! :)

If there are more suggestions, please let me know 👍

cezaraugusto
cezaraugusto previously approved these changes Feb 9, 2019
Copy link
Member

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@cezaraugusto cezaraugusto added needs +1 Needs another approval before merging and removed needs author response Changes requested needing author's input labels Feb 9, 2019
Copy link
Collaborator

@fjoshuajr fjoshuajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the comments, please.

@fjoshuajr fjoshuajr added needs author response Changes requested needing author's input and removed needs +1 Needs another approval before merging labels Feb 9, 2019
@glaucia86
Copy link
Member

@rhiroyuki

Assim que você concluir as suas mudanças, marque como 'Resolve Conversation' e altere para a label: 'changes already resolved it - translator'.
Muito obrigada pela sua contribuição! 😄

Co-Authored-By: rhiroyuki <rhiroyuki@users.noreply.github.com>
@rhiroyuki
Copy link
Contributor Author

@fjoshuajr Hi! I've committed your suggestion, tyvm 👍

@glaucia86 Dei o "Resolve Conversation" mas não consegui alterar a label, acho que não tenho permissão para isso.

Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

cc: @cezaraugusto @fjoshuajr só aprovar! :)

@glaucia86 glaucia86 added needs +1 Needs another approval before merging and removed needs author response Changes requested needing author's input labels Feb 10, 2019
Copy link
Member

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ thanks @rhiroyuki

@cezaraugusto cezaraugusto dismissed fjoshuajr’s stale review February 10, 2019 13:35

feedback addressed

@cezaraugusto cezaraugusto merged commit 676f94d into reactjs:master Feb 10, 2019
@fjoshuajr fjoshuajr added 🌐 translated Translation is completed for this page and removed needs +1 Needs another approval before merging labels Feb 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🌐 translated Translation is completed for this page

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants