Skip to content

Translate Rendering Elements #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
glaucia86 merged 5 commits into from
Feb 10, 2019
Merged

Translate Rendering Elements #49

glaucia86 merged 5 commits into from
Feb 10, 2019

Conversation

@mathsalmi
Copy link
Contributor

@mathsalmi mathsalmi commented Feb 9, 2019

#1

@fjoshuajr fjoshuajr added the needs review A pull request ready to be reviewed label Feb 9, 2019
fjoshuajr
fjoshuajr requested changes Feb 10, 2019
View reviewed changes
Copy link
Collaborator

@fjoshuajr fjoshuajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the comments, please.

@fjoshuajr fjoshuajr added needs author response Changes requested needing author's input and removed needs review A pull request ready to be reviewed labels Feb 10, 2019
fjoshuajr and others added 2 commits February 9, 2019 23:07
@fjoshuajr fjoshuajr added needs +1 Needs another approval before merging and removed needs author response Changes requested needing author's input labels Feb 10, 2019
fjoshuajr
fjoshuajr previously approved these changes Feb 10, 2019
View reviewed changes
Copy link
Collaborator

@fjoshuajr fjoshuajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks,

LGTM 🎉

glaucia86
glaucia86 approved these changes Feb 10, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mathsalmi

LGTM 👍
Queremos agradecer pela sua excelente contribuição! Muito obrigada!

@glaucia86 glaucia86 merged commit 11a9d21 into reactjs:master Feb 10, 2019
@tesseralis tesseralis mentioned this pull request Feb 10, 2019
Closed
90 tasks
@glaucia86 glaucia86 removed the needs +1 Needs another approval before merging label Feb 10, 2019
@fjoshuajr fjoshuajr added the 🌐 translated Translation is completed for this page label Feb 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@glaucia86 glaucia86 glaucia86 approved these changes

@fjoshuajr fjoshuajr fjoshuajr approved these changes

Assignees

No one assigned

Labels

🌐 translated Translation is completed for this page

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mathsalmi @glaucia86 @fjoshuajr