Skip to content

Conversation

@tibuurcio
Copy link
Collaborator

No description provided.

@tibuurcio tibuurcio added the needs review A pull request ready to be reviewed label Feb 10, 2019
Copy link
Collaborator

@fjoshuajr fjoshuajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the comments, please.

@fjoshuajr fjoshuajr added needs author response Changes requested needing author's input and removed needs review A pull request ready to be reviewed labels Feb 10, 2019
fjoshuajr and others added 2 commits February 9, 2019 22:45
Co-Authored-By: tibuurcio <tibuurcio@gmail.com>
Co-Authored-By: tibuurcio <tibuurcio@gmail.com>
@tibuurcio tibuurcio added needs review A pull request ready to be reviewed needs +1 Needs another approval before merging and removed needs author response Changes requested needing author's input needs review A pull request ready to be reviewed labels Feb 10, 2019
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tibuurcio

Algumas alterações a serem feitas. Pedimos que faça os ajustes e logo iremos aprovar a sua contribuição.
Pedimos que, conforme for realizando os acertos que marque como 'Resolve Conversation' e nos sinalize para que possamos analisar novamente a tradução e enfim, aprovar o seu PR. Muito obrigada!

@glaucia86 glaucia86 added needs author response Changes requested needing author's input and removed needs +1 Needs another approval before merging labels Feb 10, 2019
@glaucia86
Copy link
Member

@tibuurcio

Algumas alterações a serem feitas. Pedimos que faça os ajustes e logo iremos aprovar a sua contribuição.
Pedimos que, conforme for realizando os acertos que marque como 'Resolve Conversation' e nos sinalize para que possamos analisar novamente a tradução e enfim, aprovar o seu PR. Muito obrigada!

Assim que você concluir as suas mudanças, marque como 'Resolve Conversation' e altere para a label: 'changes already resolved it - translator'.
Muito obrigada pela sua contribuição! 😄

glaucia86 and others added 2 commits February 10, 2019 09:47
Co-Authored-By: tibuurcio <tibuurcio@gmail.com>
Co-Authored-By: tibuurcio <tibuurcio@gmail.com>
@tibuurcio tibuurcio added needs resolution Something not defined that needs maintainers input feedback addressed and removed needs author response Changes requested needing author's input needs resolution Something not defined that needs maintainers input labels Feb 10, 2019
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

cc: @cezaraugusto @fjoshuajr só aprovar

@glaucia86
Copy link
Member

@tibuurcio

Queremos agradecer pela sua excelente contribuição! Muito obrigada!

@glaucia86 glaucia86 added needs +1 Needs another approval before merging and removed feedback addressed labels Feb 10, 2019
Copy link
Member

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@cezaraugusto cezaraugusto dismissed fjoshuajr’s stale review February 10, 2019 15:47

feedback addressed

@cezaraugusto cezaraugusto merged commit 8a1c07f into reactjs:master Feb 10, 2019
@cezaraugusto cezaraugusto added 🌐 translated Translation is completed for this page and removed needs +1 Needs another approval before merging labels Feb 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🌐 translated Translation is completed for this page

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants