Skip to content

Comments

[CodeQuality] Handle crash first class callable on InlineArrayReturnAssignRector#6763

Merged
samsonasik merged 1 commit intomainfrom
crash-first
Mar 2, 2025
Merged

[CodeQuality] Handle crash first class callable on InlineArrayReturnAssignRector#6763
samsonasik merged 1 commit intomainfrom
crash-first

Conversation

@samsonasik
Copy link
Member

@TomasVotruba your PR

cause crash on first class callable

There was 1 failure:

1) Rector\Tests\CodeQuality\Rector\ClassMethod\InlineArrayReturnAssignRector\InlineArrayReturnAssignRectorTest::test with data set #12 ('/Users/samsonasik/www/rector-...hp.inc')
assert(!$this->isFirstClassCallable())

/Users/samsonasik/www/rector-src/vendor/nikic/php-parser/lib/PhpParser/Node/Expr/CallLike.php:32
/Users/samsonasik/www/rector-src/rules/CodeQuality/Rector/ClassMethod/InlineArrayReturnAssignRector.php:193

This PR fix it.

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit a732689 into main Mar 2, 2025
44 checks passed
@samsonasik samsonasik deleted the crash-first branch March 2, 2025 15:31
@TomasVotruba
Copy link
Member

Good point, thanks 👍

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2025

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants