[CodeQuality] Mirror comment on InlineConstructorDefaultToPropertyRector#7074
Merged
samsonasik merged 5 commits intomainfrom Jul 20, 2025
Merged
[CodeQuality] Mirror comment on InlineConstructorDefaultToPropertyRector#7074samsonasik merged 5 commits intomainfrom
samsonasik merged 5 commits intomainfrom
Conversation
Member
Author
|
Fixed 🎉 /cc @calebdw |
07390d2 to
bf9a79d
Compare
Member
Author
|
All checks have passed 🎉 @TomasVotruba I am merging it to have faster feedback to test ;) |
samsonasik
added a commit
that referenced
this pull request
Jul 21, 2025
…tor (#7074) * [CodeQuality] Mirror comment on InlineConstructorDefaultToPropertyRector * clean * clean * clean * [ci-review] Rector Rectify --------- Co-authored-by: GitHub Action <actions@github.com>
Contributor
|
This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#9273
Note:
On multiple props on single property definitions:
The multiple comments will be merged as is:
/** * some existing comment */ + // first + // second + // third private $thing1, $thing2, $thing3;then, phpdoc info will require rebuild by set it to null.I add
$mergeExistingCommentsflag that set tofalseonmirrorCommentsmethod onAbstractRectorto avoid regression on other existing rules.