[internal] Make consistent to continue outer loop when subnode type changed on AbstractImmutableNodeTraverser#7766
Merged
samsonasik merged 1 commit intomainfrom Dec 22, 2025
Merged
Conversation
…hanged on AbstractImmutableNodeTraverser
Member
Author
|
@TomasVotruba ready 👍, let's merge to make consistent behaviour and ensure nothing left behind :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per #7717 (review)
This continue of PR:
to use same behaviour to continue to outer loop to ensure nothing left behind, while keep improve the performance to no longer need continue loop on current visitor for node.