Skip to content

Conversation

@masenf
Copy link
Collaborator

@masenf masenf commented Nov 15, 2025

No description provided.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 15, 2025

CodSpeed Performance Report

Merging #5982 will not alter performance

Comparing masenf/polling-for-all (039983f) with main (3617ee4)

Summary

✅ 8 untouched

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Nov 15, 2025

Greptile Overview

Greptile Summary

This PR removes the enterprise-tier restriction for using transport="polling" in Reflex applications. Previously, only enterprise users could use polling transport; this change democratizes the feature for all users.

  • Removed tier check that prevented non-enterprise users from using polling transport
  • Eliminates the SystemExit(1) error that would block app initialization for non-enterprise users with polling enabled
  • No other logic changes to socket configuration or transport handling

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The change is a straightforward removal of a feature gate that removes a restriction rather than adding new logic, reducing risk of bugs. No new code paths are introduced, only an existing restriction is lifted.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
reflex/app.py 5/5 Removed enterprise-tier restriction for transport="polling" option, making it available to all users

Sequence Diagram

sequenceDiagram
    participant User
    participant App
    participant Config
    participant AsyncServer

    User->>App: Initialize app with config
    App->>Config: get_config()
    Config-->>App: config (transport setting)
    
    alt Before this PR (transport="polling" for non-enterprise)
        App->>App: Check tier with prerequisites.get_user_tier()
        App->>App: Raise SystemExit(1) if not enterprise
    end
    
    Note over App: After this PR: No tier check
    
    App->>AsyncServer: Create AsyncServer with transports=[config.transport]
    AsyncServer-->>App: Socket server instance
    App->>App: Configure event namespace
    App->>App: Mount socket app
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@adhami3310 adhami3310 merged commit a8bf59e into main Nov 15, 2025
47 checks passed
@adhami3310 adhami3310 deleted the masenf/polling-for-all branch November 15, 2025 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants