Replace duplicate files with a build script#135
Merged
robinmoisson merged 1 commit intorobinmoisson:mainfrom Oct 30, 2022
Merged
Replace duplicate files with a build script#135robinmoisson merged 1 commit intorobinmoisson:mainfrom
robinmoisson merged 1 commit intorobinmoisson:mainfrom
Conversation
hurrymaplelad
commented
Oct 23, 2022
| @@ -1,4 +1,6 @@ | |||
| .idea | |||
| node_modules | |||
| cli/.staticrypt.json | |||
Contributor
Author
There was a problem hiding this comment.
This was redundant. .staticrypt.json matches subdirectories as well.
Owner
|
Hey @hurrymaplelad - thanks for your PRs! That's all looking great. I've been bitten bitten by the duplicated files and been wanting to automate all of that for a while, and really like your approach here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Neat project! I'd like to contribute more. These changes should make that easier.
See README.md for new build and test instructions.
Committing copies of files like
password_template.htmlcomplicates merging and rebase, which bit me while experimenting with thewebcryptobranch.I added a
package.jsonfilesallowlist to keep the new build script from bloating the published package.I verified the files that would be published with
npm run build && npm package --dry-run: