Convert Listings in Chapter 09 to <Listing>#3980
Merged
chriskrycho merged 20 commits intorust-lang:mainfrom Oct 15, 2024
Merged
Convert Listings in Chapter 09 to <Listing>#3980chriskrycho merged 20 commits intorust-lang:mainfrom
<Listing>#3980chriskrycho merged 20 commits intorust-lang:mainfrom
Conversation
(had to fix a merge conflict here)
(had to fix a conflect here)
I removed the line break in Listing 9-12, which I apparently forgot in the previous commit. I did realize that I will evetually have to re-add these to comply with the 80 character width limit, but for now I want to stay consistent with my current implementation. (Had to fix a conflict here)
…cter limit More infos and concerns can be found in the equivalent commit in the chapter 6 PR. (Had to fix a conflict here)
Contributor
Author
|
Just realized that this specific PR has an issue that I still need to fix up. I'll do it soon. |
21 tasks
Contributor
|
@SpectralPixel if you let me know what the specific issue was with this PR, I’m happy to fix that up along with the wrapping issue I am fixing! |
…l 80 character limit" This backs out commit dd72f8f.
Contributor
Author
|
I believe by reverting commit the issue should be fixed. The checks state that it's ready to be merged. Thanks for helping me out with this :) |
Contributor
|
No problem! 👍🏼 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finally, here is chapter 09 adapted to the new
<Listing>pre-processor. I'm not sure if everything works as intended since I couldn't getmdbookto behave properly on my machine, so please check the sanity of my changes.I also changed numberless listings (as in, they have a file name, but no number), so feel free to revert those commits if they are not yet fully functional by the time they will be merged.
Please also check all the comments I have left in commit descriptions and the issue thread for further concerns I might have about the code.
(By the way, I also fixed some conflicts while moving the commits around)
Issue #3919