docs(contrib): Add documentation for ui tests#10758
Merged
bors merged 2 commits intorust-lang:masterfrom Jun 20, 2022
Merged
Conversation
|
r? @ehuss (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Muscraft
reviewed
Jun 17, 2022
Member
Muscraft
left a comment
Muscraft
left a comment
There was a problem hiding this comment.
I like the changes. It covers snapbox and UI tests really well
This only adds information about snapshot testing using `snapbox` and keeps the functional testing documentation focused on the existing facilities. We can updated this as our use of `snapbox` matures. In writing this, I did notice that we define `cargo_test_support::compare::assert` but only use it for filesystem asserts and not binary asserts. We should probably add our own function that wraps `snapbox::cmd::Command::cargo()` and passes in `cargo_test_support::compare::assert`. I've left that out of this PR to keep things focused.
weihanglo
approved these changes
Jun 20, 2022
Member
weihanglo
left a comment
weihanglo
left a comment
There was a problem hiding this comment.
Looks really nice! Love the re-structure.
Member
|
Thanks! @bors r+ |
Contributor
|
📌 Commit 619630c has been approved by |
bors
added
S-waiting-on-bors
Contributor
Contributor
|
☀️ Test successful - checks-actions |
arlosi
added a commit
to arlosi/rust
that referenced
this pull request
Jun 23, 2022
8 commits in 03a849043e25104e8b7ad0d4a96c525787b69379..a5e08c4703f202e30cdaf80ca3e7c00baa59c496 2022-06-20 14:47:36 +0000 to 2022-06-23 20:12:03 +0000 - Fix tests due to change in dead_code diagnostic. (rust-lang/cargo#10785) - Stabilize config-cli (rust-lang/cargo#10755) - Restrict duplicate deps warning only to published packages (rust-lang/cargo#10767) - Use fingerprint_hash when computing fingerprints for custom targets (rust-lang/cargo#10746) - Add preloading for workspace packages in `resolve_with_previous` (rust-lang/cargo#10761) - capitalise, for consistency (rust-lang/cargo#10772) - remove unused dependency from benchsuite (rust-lang/cargo#10774) - docs(contrib): Add documentation for ui tests (rust-lang/cargo#10758)
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 24, 2022
Update cargo 8 commits in 03a849043e25104e8b7ad0d4a96c525787b69379..a5e08c4703f202e30cdaf80ca3e7c00baa59c496 2022-06-20 14:47:36 +0000 to 2022-06-23 20:12:03 +0000 - Fix tests due to change in dead_code diagnostic. (rust-lang/cargo#10785) - Stabilize config-cli (rust-lang/cargo#10755) - Restrict duplicate deps warning only to published packages (rust-lang/cargo#10767) - Use fingerprint_hash when computing fingerprints for custom targets (rust-lang/cargo#10746) - Add preloading for workspace packages in `resolve_with_previous` (rust-lang/cargo#10761) - capitalise, for consistency (rust-lang/cargo#10772) - remove unused dependency from benchsuite (rust-lang/cargo#10774) - docs(contrib): Add documentation for ui tests (rust-lang/cargo#10758)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
This only adds information about snapshot testing using
snapboxandkeeps the functional testing documentation focused on the existing
facilities. We can updated this as our use of
snapboxmatures.How should we test and review this PR?
I did not generate and verify the HTML
In writing this, I did notice that we define
cargo_test_support::compare::assertbut only use it for filesystemasserts and not binary asserts. We should probably add our own function
that wraps
snapbox::cmd::Command::cargo()and passes incargo_test_support::compare::assert. I've left that out of this PR tokeep things focused.