Correct the bug report for cargo clippy --fix#11882
Merged
bors merged 3 commits intorust-lang:masterfrom Apr 14, 2023
Merged
Conversation
Collaborator
|
r? @weihanglo (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
A-build-execution
0xPoe
commented
Mar 24, 2023
Member
Author
0xPoe
left a comment
0xPoe
left a comment
There was a problem hiding this comment.
I am trying to add a test for it. But it seems to be a bit difficult. If you have any suggestions please let me now. Thanks!
Member
|
Some tests like |
Member
Author
Yeah, I am trying to combine it with |
This comment was marked as outdated.
This comment was marked as outdated.
0xPoe
force-pushed
the
rustin-patch-clippy-fix
branch
from
b19d697 to
dc05b30
Compare
Member
Author
|
@weihanglo Friendly ping~ |
0xPoe
force-pushed
the
rustin-patch-clippy-fix
branch
from
dc05b30 to
2dfcca3
Compare
weihanglo
reviewed
Apr 13, 2023
Member
weihanglo
left a comment
weihanglo
left a comment
There was a problem hiding this comment.
Thanks for the fix! I don't think we'll have more tools in a near future, so this hard-coded solution effectively fixes the issue IMO.
Only some minor suggestions.
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
0xPoe
force-pushed
the
rustin-patch-clippy-fix
branch
from
2dfcca3 to
47f6e2d
Compare
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Member
Author
Thanks for your review! 💚 💙 💜 💛 ❤️ All addressed! |
weihanglo
approved these changes
Apr 14, 2023
Member
weihanglo
left a comment
weihanglo
left a comment
There was a problem hiding this comment.
Looks pretty good. Thanks for the update!
Member
|
@bors r+ |
Contributor
bors
added
S-waiting-on-bors
Contributor
Contributor
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 16, 2023
…ehuss Make cargo a workspace 8 commits in 7bf43f028ba5eb1f4d70d271c2546c38512c9875..39116ccc9b420a883a98a960f0597f9cf87414b8 2023-04-10 16:01:41 +0000 to 2023-04-15 20:24:15 +0000 - Make cargo a workspace (rust-lang/cargo#11851) - Fix flaky not_found_permutations test. (rust-lang/cargo#11976) - Use restricted Damerau-Levenshtein algorithm (rust-lang/cargo#11963) - Correct the bug report for `cargo clippy --fix` (rust-lang/cargo#11882) - Stabilize `cargo logout` (rust-lang/cargo#11950) - Add more information to HTTP errors to help with debugging. (rust-lang/cargo#11878) - Use registry.default for login/logout (rust-lang/cargo#11949) - Change -C to be unstable (rust-lang/cargo#11960) --- ### What does this PR try to resolve? Making cargo a workspace. Why doing this? * `rustc-workspace-hack` is primarily for sharing dependencies between rls and cargo, as rls previously depends on cargo. After rls retired, it is no longer the case sharing dependencies. * It's q bit painful that cargo needs to deal with some dependency and licensing complexities. For example, rust-lang#108665 failed because of the interaction bewteen `windows-sys` and `raw-dylib`. It currenctly blocks cargo's feature `-Zgitxodie` from moving forward. * See rust-lang/cargo#11851 ### Benchmark result I've done a simple benchmark on both keeping or removing entire `rustc-workspace-hack`. It had no significant difference. Both took ~2m30s to finish `./x.py build -j8 src/tools/cargo src/tools/rls src/tools/clippy src/tools/miri src/tools/rustfmt`. Environment info: ``` host: aarch64-apple-darwin os: Mac OS 13.2.1 [64-bit] ``` A sophisticated benchmark may be needed. ### Additional information This depends on prior works from `@Muscraft` and `@ehuss.` Credits to them!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
close #11877
Correct the bug report for
cargo clippy --fix.How should we test and review this PR?
See the unit tests.