test: migrate install* and inheritable_workspace_fields to snapbox#14170
Merged
bors merged 3 commits intorust-lang:masterfrom Jul 4, 2024
Merged
test: migrate install* and inheritable_workspace_fields to snapbox#14170bors merged 3 commits intorust-lang:masterfrom
bors merged 3 commits intorust-lang:masterfrom
Conversation
Collaborator
|
r? @weihanglo rustbot has assigned @weihanglo. Use |
rustbot
added
the
S-waiting-on-review
eth3lbert
force-pushed
the
snapbox-i
branch
4 times, most recently
from
c27d3f9 to
a6a587f
Compare
eth3lbert
commented
Jun 30, 2024
| assert_eq!(lock, lock2, "different lockfiles"); | ||
| } | ||
|
|
||
| #[allow(deprecated)] |
Contributor
Author
There was a problem hiding this comment.
with_stderr_does_not_contain is being used in this function.
| .run(); | ||
| } | ||
|
|
||
| #[allow(deprecated)] |
Contributor
Author
There was a problem hiding this comment.
with_stderr_does_not_contain is being used in this function.
| .run(); | ||
| } | ||
|
|
||
| #[allow(deprecated)] |
Contributor
Author
There was a problem hiding this comment.
with_stderr_does_not_contain is being used in this function.
Comment on lines
+2091
to
+2160
| .with_stderr_data(str![[r#" | ||
| [UPDATING] git repository `[ROOTURL]/foo` | ||
| [ERROR] invalid type: integer `3`, expected a boolean | ||
| --> home/.cargo/git/checkouts/foo-[HASH]/[..]/Cargo.toml:6:27 | ||
| | | ||
| 6 | incremental = 3 | ||
| | ^ | ||
| | | ||
| [ERROR] invalid type: integer `3`, expected a boolean | ||
| --> home/.cargo/git/checkouts/foo-[HASH]/[..]/Cargo.toml:6:27 | ||
| | | ||
| 6 | incremental = 3 | ||
| | ^ | ||
| | | ||
|
|
||
| "#]]) |
Contributor
Author
There was a problem hiding this comment.
I'm not sure if the duplicated error message shown here is correct. Therefore, I'm currently avoiding redacting with glob intentionally.
weihanglo
reviewed
Jul 3, 2024
| .with_stderr( | ||
| "\ | ||
| [UPDATING] `[..]` index | ||
| .with_stderr_data(str![[r#" |
Member
There was a problem hiding this comment.
Could we allow deprecated for all --message-format=json tests?
The snapshot is hard to read and review so we don't want to do it now.
Contributor
Author
There was a problem hiding this comment.
Absolutely! That makes things a lot easier, to be honest. 😅
tests/testsuite/install.rs
Outdated
| .with_stderr_contains("[INSTALLING] bar v0.0.1") | ||
| .with_stderr_contains("[..]--target nonexistent[..]") | ||
| .with_stderr_data(str![[r#" | ||
| ... |
Member
There was a problem hiding this comment.
[INSTALLING] bar v0.0.1 is missing, though I think that is fine.
Contributor
Author
There was a problem hiding this comment.
I'll double-check this and re-add it.
Comment on lines
+2091
to
+2160
| .with_stderr_data(str![[r#" | ||
| [UPDATING] git repository `[ROOTURL]/foo` | ||
| [ERROR] invalid type: integer `3`, expected a boolean | ||
| --> home/.cargo/git/checkouts/foo-[HASH]/[..]/Cargo.toml:6:27 | ||
| | | ||
| 6 | incremental = 3 | ||
| | ^ | ||
| | | ||
| [ERROR] invalid type: integer `3`, expected a boolean | ||
| --> home/.cargo/git/checkouts/foo-[HASH]/[..]/Cargo.toml:6:27 | ||
| | | ||
| 6 | incremental = 3 | ||
| | ^ | ||
| | | ||
|
|
||
| "#]]) |
Contributor
Author
|
Feedback addressed! Thanks! |
weihanglo
approved these changes
Jul 4, 2024
Member
|
Thanks! @bors r+ |
Contributor
bors
added
S-waiting-on-bors
Contributor
Contributor
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 5, 2024
Update cargo 13 commits in a515d463427b3912ec0365d106791f88c1c14e1b..f86ce56396168edf5d0e1c412ddda0b2edba7d46 2024-07-02 20:53:36 +0000 to 2024-07-05 17:52:05 +0000 - test: Migrate jobserver to snapbox (rust-lang/cargo#14191) - chore(deps): update msrv (3 versions) to v1.77 (rust-lang/cargo#14186) - test: migrate build_plan and build_script to snapbox (rust-lang/cargo#14193) - test: migrate cfg and check to snapbox (rust-lang/cargo#14185) - test: migrate install* and inheritable_workspace_fields to snapbox (rust-lang/cargo#14170) - Pass rustflags to artifacts built with implicit targets when using target-applies-to-host (rust-lang/cargo#13900) - test: Migrate network tests to snapbox (rust-lang/cargo#14187) - test: migrate some files to snapbox (rust-lang/cargo#14113) - test: Auto-redact `... after last build at ...`; Migrate `freshness` to Snapbox (rust-lang/cargo#14161) - chore: fix some typos (rust-lang/cargo#14182) - fix: improve message for inactive weak optional feature with edition2024 through unused dep collection (rust-lang/cargo#14026) - test：migrate `doc/directory/docscrape` to snapbox (rust-lang/cargo#14171) - test: Migrate git_auth to snapbox (rust-lang/cargo#14172)
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 7, 2024
Update cargo 20 commits in a515d463427b3912ec0365d106791f88c1c14e1b..154fdac39ae9629954e19e9986fd2cf2cdd8d964 2024-07-02 20:53:36 +0000 to 2024-07-07 01:28:23 +0000 - test: relax redactions for rust-lang/rust (rust-lang/cargo#14203) - use "bootstrap" instead of "rustbuild" (rust-lang/cargo#14207) - test: migrate serveral files to snapbox (rust-lang/cargo#14180) - Add rustdocflags to Unit's Debug impl (rust-lang/cargo#14201) - Allow enabling `config-include` feature in config (rust-lang/cargo#14196) - fix(test): Restore `does_not_contain` for check (rust-lang/cargo#14198) - test: migrate patch, pkgid, proc_macro and progress to snapbox (rust-lang/cargo#14181) - test: Migrate jobserver to snapbox (rust-lang/cargo#14191) - chore(deps): update msrv (3 versions) to v1.77 (rust-lang/cargo#14186) - test: migrate build_plan and build_script to snapbox (rust-lang/cargo#14193) - test: migrate cfg and check to snapbox (rust-lang/cargo#14185) - test: migrate install* and inheritable_workspace_fields to snapbox (rust-lang/cargo#14170) - Pass rustflags to artifacts built with implicit targets when using target-applies-to-host (rust-lang/cargo#13900) - test: Migrate network tests to snapbox (rust-lang/cargo#14187) - test: migrate some files to snapbox (rust-lang/cargo#14113) - test: Auto-redact `... after last build at ...`; Migrate `freshness` to Snapbox (rust-lang/cargo#14161) - chore: fix some typos (rust-lang/cargo#14182) - fix: improve message for inactive weak optional feature with edition2024 through unused dep collection (rust-lang/cargo#14026) - test：migrate `doc/directory/docscrape` to snapbox (rust-lang/cargo#14171) - test: Migrate git_auth to snapbox (rust-lang/cargo#14172)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
Part of #14039.
Migrate following to snapbox:
tests/testsuite/inheritable_workspace_fields.rstests/testsuite/install.rstests/testsuite/install_upgrade.rs