Migrate global_cache_tracker snapbox#14244
Merged
bors merged 2 commits intorust-lang:masterfrom Jul 17, 2024
Merged
Conversation
Collaborator
rustbot
added
A-testing-cargo-itself
Contributor
How about we skip those specific tests for now and focus on getting the rest of this in? |
Contributor
|
☔ The latest upstream changes (presumably #14243) made this pull request unmergeable. Please resolve the merge conflicts. |
dieterplex
force-pushed
the
migrate-gct-snapbox
branch
3 times, most recently
from
e4c9001 to
56dde27
Compare
Contributor
Author
Added |
dieterplex
force-pushed
the
migrate-gct-snapbox
branch
2 times, most recently
from
5faffc3 to
f885706
Compare
epage
reviewed
Jul 16, 2024
dieterplex
force-pushed
the
migrate-gct-snapbox
branch
from
f885706 to
1afdad1
Compare
dieterplex
force-pushed
the
migrate-gct-snapbox
branch
from
1afdad1 to
c839120
Compare
epage
reviewed
Jul 16, 2024
dieterplex
force-pushed
the
migrate-gct-snapbox
branch
from
c839120 to
8686273
Compare
Contributor
|
@bors r+ |
Contributor
bors
added
S-waiting-on-bors
Contributor
Contributor
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 21, 2024
Update cargo 9 commits in a2b58c3dad4d554ba01ed6c45c41ff85390560f2..5f6b9a92201d78af75dc24f14662c3e2dacbbbe1 2024-07-16 00:52:02 +0000 to 2024-07-19 18:09:17 +0000 - Add `TomlPackage::new`, `Default` for `TomlWorkspace` (rust-lang/cargo#14271) - fix(test): Move 'cargo_home' from 'install' to 'paths' (rust-lang/cargo#14270) - fix(test)!: Clarify extension trait role with rename (rust-lang/cargo#14269) - feat(test): Re-export ProcessBuilder (rust-lang/cargo#14268) - fix(test): Move path2url to CargoPathExt::to_url (rust-lang/cargo#14266) - Fix passing of links-overrides with target-applies-to-host and an implicit target (rust-lang/cargo#14205) - fix(toml): Improve error on missing package and workspace (rust-lang/cargo#14261) - Migrate global_cache_tracker snapbox (rust-lang/cargo#14244) - make summary sync by using Arc not Rc (rust-lang/cargo#14260)
lnicola
pushed a commit
to lnicola/rust-analyzer
that referenced
this pull request
Jul 28, 2024
Update cargo 9 commits in a2b58c3dad4d554ba01ed6c45c41ff85390560f2..5f6b9a92201d78af75dc24f14662c3e2dacbbbe1 2024-07-16 00:52:02 +0000 to 2024-07-19 18:09:17 +0000 - Add `TomlPackage::new`, `Default` for `TomlWorkspace` (rust-lang/cargo#14271) - fix(test): Move 'cargo_home' from 'install' to 'paths' (rust-lang/cargo#14270) - fix(test)!: Clarify extension trait role with rename (rust-lang/cargo#14269) - feat(test): Re-export ProcessBuilder (rust-lang/cargo#14268) - fix(test): Move path2url to CargoPathExt::to_url (rust-lang/cargo#14266) - Fix passing of links-overrides with target-applies-to-host and an implicit target (rust-lang/cargo#14205) - fix(toml): Improve error on missing package and workspace (rust-lang/cargo#14261) - Migrate global_cache_tracker snapbox (rust-lang/cargo#14244) - make summary sync by using Arc not Rc (rust-lang/cargo#14260)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #14039.
Some of these tests may require to assert specific removed file count or size that would be redact by current design. Need feedback to come out solution.
Temporary commit to pass the tests and illustrate what need to fix.