Closed
Conversation
Collaborator
rustbot
added
the
S-waiting-on-review
Member
Author
|
Perhaps the terminal detection is drifted between Cargo and anstyle. Given it is not an issue on our CI, let me turn this into an issue. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 6, 2025
In #15639, @weihanglo noted that one of the lint tests passed in CI, but locally it would fail as it had a hyperlink added to its output. The root cause appears to be the recent update to `anstyle-svg@0.1.8`, which added support for hyperlinks, combined with our hyperlink support autodetection, disabling them in CI, but allowing them locally. To ensure we are consistently handling hyperlinks, I made them always enabled for UI tests. This seemed like the best option given that we already force colors for UI tests, and it allows us to test our hyperlink output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Haven't figured out why CI was green, but it failed on my machine.