implement default-run option to set default binary for cargo run#5710
implement default-run option to set default binary for cargo run#5710bors merged 5 commits intorust-lang:masterfrom
Conversation
|
r? @matklad (rust_highfive has picked a reviewer for you, use r? to override) |
|
Thanks! Could this be placed behind a Cargo feature though to avoid it being insta-stable? |
|
All right, I will look into how to do that. |
|
I hope I did this right =D |
alexcrichton
left a comment
alexcrichton
left a comment
There was a problem hiding this comment.
Looks great, thanks! Could this also include some documentation in src/doc for this new nightly feature?
src/cargo/ops/cargo_run.rs
Outdated
There was a problem hiding this comment.
I think we may want to hold off on changing the error message here because the feature is unstable, but once stabilized seems reasonable to change!
There was a problem hiding this comment.
I agree; I forgot to revert this after making the feature unstable.
src/cargo/ops/cargo_run.rs
Outdated
|
Done. |
|
Fixed conflicts. |
|
@bors: r+ |
|
📌 Commit 34a5cfb has been approved by |
implement default-run option to set default binary for cargo run The implementation is not pretty but as good as I could make it. The fact that all this logic in `cargo_run` is for diagnosis only and essentially just re-implements the filtering done elsewhere really threw me off. Fixes #2200
|
☀️ Test successful - status-appveyor, status-travis |
|
Is this feature intended to go live on stable? If so, what needs to happen before it does? |
|
@dhbradshaw I just filed a tracking issue at #7032, and nominated it for stabilization. |
7 participants
The implementation is not pretty but as good as I could make it. The fact that all this logic in
cargo_runis for diagnosis only and essentially just re-implements the filtering done elsewhere really threw me off.Fixes #2200