Only load ~/.cargo/config for cargo install#6026
Conversation
|
r? @matklad (rust_highfive has picked a reviewer for you, use r? to override) |
|
r? @ehuss |
dwijnand
left a comment
There was a problem hiding this comment.
LGTM!
Had a look at the issue when it was opened so it's interesting to see how you solved this.
Is this going to be blocked on indiv0/lazycell#90 being reviewed, merged and released, I wonder?
|
Thanks! Yeah we'll need to wait for that PR to merge, but if it doesn't happen in the next few days I'll figure out another strategy |
ehuss
left a comment
There was a problem hiding this comment.
Looks good once the lazycell release is resolved.
|
I would (loosely) expect that cargo install with a (Generally it seems like I want an option to override this PR and say "no use this cargo config") |
|
@Mark-Simulacrum that seems plausible to me too! I think I'll leave that for a future PR though :) |
|
I agree, best fix the regression in #6025 before stretching for Mark's use case, imo. |
This commit tweaks how configuration is loaded for `cargo install`, ensuring that we only load configuration from `$HOME` instead of the current working directory. This should make installations a little more consistent in that they probably shouldn't cover project-local configuration but should respect global configuration! Closes rust-lang#6025
6404952 to
d9534bf
Compare
|
@bors: r=ehuss |
|
📌 Commit d9534bf has been approved by |
Only load `~/.cargo/config` for `cargo install` This commit tweaks how configuration is loaded for `cargo install`, ensuring that we only load configuration from `$HOME` instead of the current working directory. This should make installations a little more consistent in that they probably shouldn't cover project-local configuration but should respect global configuration! Closes #6025
|
☀️ Test successful - status-appveyor, status-travis |
This commit tweaks how configuration is loaded for
cargo install, ensuringthat we only load configuration from
$HOMEinstead of the current workingdirectory. This should make installations a little more consistent in that they
probably shouldn't cover project-local configuration but should respect global
configuration!
Closes #6025