Skip to content

Add _NSGetArgv, _NSGetArgc and _NSGetProgname from crt_externs.h#3702

Merged
tgross35 merged 1 commit intorust-lang:mainfrom
madsmtm:apple-crt-externs
Aug 13, 2024
Merged

Add _NSGetArgv, _NSGetArgc and _NSGetProgname from crt_externs.h#3702
tgross35 merged 1 commit intorust-lang:mainfrom
madsmtm:apple-crt-externs

Conversation

@madsmtm
Copy link
Contributor

@madsmtm madsmtm commented May 15, 2024

Available in the headers on all Apple platforms.

@rustbot
Copy link
Collaborator

rustbot commented May 15, 2024

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@madsmtm
Copy link
Contributor Author

madsmtm commented May 15, 2024

The CI timeout seems to be unrelated

@madsmtm madsmtm force-pushed the apple-crt-externs branch from 11b9d5e to 316c7df Compare May 17, 2024 20:43
@tgross35
Copy link
Contributor

This lgtm, reference here https://opensource.apple.com/source/Libc/Libc-320/include/crt_externs.h.auto.html.

Can you target main? We can backport if needed.

@rustbot label +stable-nominated
@rustbot author

@rustbot rustbot added stable-nominated This PR should be considered for cherry-pick to libc's stable release branch S-waiting-on-author and removed S-waiting-on-review labels Aug 12, 2024
@madsmtm madsmtm changed the base branch from libc-0.2 to main August 13, 2024 01:26
Available in the headers on all Apple platforms.
@madsmtm madsmtm force-pushed the apple-crt-externs branch from 316c7df to 4333c2f Compare August 13, 2024 01:29
@madsmtm
Copy link
Contributor Author

madsmtm commented Aug 13, 2024

Can you target main

Sure! @rustbot ready

@tgross35
Copy link
Contributor

Thanks!

@tgross35 tgross35 enabled auto-merge August 13, 2024 01:30
@tgross35 tgross35 added this pull request to the merge queue Aug 13, 2024
Merged via the queue into rust-lang:main with commit 4351675 Aug 13, 2024
@madsmtm madsmtm deleted the apple-crt-externs branch August 13, 2024 11:47
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Aug 16, 2024
Available in the headers on all Apple platforms.

(backport <rust-lang#3702>)
(cherry picked from commit 4333c2f)
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Aug 16, 2024
jhpratt added a commit to jhpratt/rust that referenced this pull request Feb 18, 2026
std: use libc version of `_NSGetArgc`/`_NSGetArgv`

These were added to libc in rust-lang/libc#3702.
jhpratt added a commit to jhpratt/rust that referenced this pull request Feb 18, 2026
std: use libc version of `_NSGetArgc`/`_NSGetArgv`

These were added to libc in rust-lang/libc#3702.
Zalathar added a commit to Zalathar/rust that referenced this pull request Feb 18, 2026
std: use libc version of `_NSGetArgc`/`_NSGetArgv`

These were added to libc in rust-lang/libc#3702.
rust-timer added a commit to rust-lang/rust that referenced this pull request Feb 18, 2026
Rollup merge of #152672 - joboet:apple_args_libc, r=jhpratt

std: use libc version of `_NSGetArgc`/`_NSGetArgv`

These were added to libc in rust-lang/libc#3702.
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Feb 19, 2026
std: use libc version of `_NSGetArgc`/`_NSGetArgv`

These were added to libc in rust-lang/libc#3702.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments