test padding in format strings#626
Merged
RalfJung merged 4 commits intorust-lang:masterfrom Feb 13, 2019
Merged
Conversation
emilyalbini
added a commit
to emilyalbini/rust
that referenced
this pull request
Feb 10, 2019
miri: give non-generic functions a stable address This makes Miri correctly handle format string parameters despite rust-lang#58320. Matching Miri PR: rust-lang/miri#626 r? @oli-obk
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Feb 10, 2019
miri: give non-generic functions a stable address This makes Miri correctly handle format string parameters despite rust-lang#58320. Matching Miri PR: rust-lang/miri#626 r? @oli-obk
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Feb 10, 2019
miri: give non-generic functions a stable address This makes Miri correctly handle format string parameters despite rust-lang#58320. Matching Miri PR: rust-lang/miri#626 r? @oli-obk
RalfJung
added
S-waiting-on-nightly
and removed
S-blocked-on-rust
Member
Author
|
Somehow the "is_generic" stuff doesn't work... even for a function like fn f<T: Default>() -> T {
Default::default()
}when turning it to a function pointer, I am seeing How can |
Member
Author
|
Oh never mind... I edited the wrong checkout of Miri... ^^ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Waiting for rust-lang/rust#58324 to land