fix: Fix loses associated bounds for replace_derive_with_manual_impl#21583
Merged
ShoyuVanilla merged 2 commits intorust-lang:masterfrom Feb 10, 2026
Merged
fix: Fix loses associated bounds for replace_derive_with_manual_impl#21583ShoyuVanilla merged 2 commits intorust-lang:masterfrom
ShoyuVanilla merged 2 commits intorust-lang:masterfrom
Conversation
Example
---
```rust
#[derive(Clo$0ne)]
struct Foo<T: core::ops::Deref>(T::Target);
```
**Before this PR**
```rust
struct Foo<T: core::ops::Deref>(T::Target);
impl<T: core::ops::Deref + Clone> Clone for Foo<T> {
$0fn clone(&self) -> Self {
Self(self.0.clone())
}
}
```
**After this PR**
```rust
struct Foo<T: core::ops::Deref>(T::Target);
impl<T: core::ops::Deref + Clone> Clone for Foo<T>
where T::Target: Clone
{
$0fn clone(&self) -> Self {
Self(self.0.clone())
}
}
```
ShoyuVanilla
reviewed
Feb 9, 2026
crates/ide-assists/src/utils.rs
Outdated
| trait_, | ||
| ty, | ||
| None, | ||
| trait_where_clause, |
Member
There was a problem hiding this comment.
This behaves correctly, but the variable name and passing it as the param with the same name might be misleading. We’re collecting clauses from the ADT here, not from the trait.
ShoyuVanilla
approved these changes
Feb 10, 2026
Member
There was a problem hiding this comment.
rust-analyzer/crates/syntax/src/ast/make.rs
Lines 324 to 337 in 9efc1f7
We might need to improve the above API as well to accept iterator or sth for where clauses but I think this PR is good as is for now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19878
Example
Before this PR
After this PR