vscode problem matcher improvements#408
Merged
bors[bot] merged 2 commits intorust-lang:masterfrom Jan 2, 2019
Merged
Conversation
Contributor
|
bors r+ Thanks! |
bors bot
added a commit
that referenced
this pull request
Jan 2, 2019
408: vscode problem matcher improvements r=matklad a=vemoo The problem matcher wasn't working properly and looking at the rustc errors i realized it could be simplified. I also added a new problem matcher that can be used with https://github.com/passcod/cargo-watch to get the errors in the editor on save. To use it one can create a tasks.json file with: ```json { "version": "2.0.0", "tasks": [ { "type": "shell", "label": "cargo watch", "command": "cargo", "isBackground": true, "args": [ "watch", "-c" ], "problemMatcher": [ "$rustc-watch" ] } ] } ``` I initially implemented it like this: cff9f62 but i think there's a bug in vscode so i worked around it by copying the pattern for both problem matchers. The first commit can be used if microsoft/vscode#65840 is merged. Co-authored-by: Bernardo <berublan@gmail.com>
Contributor
Build succeededAnd happy new year from bors! 🎉 |
kjeremy
added a commit
to kjeremy/rust-analyzer
that referenced
this pull request
Feb 18, 2019
Now that microsoft/vscode#65840 is in the latest release we can use the first commit from rust-lang#408
bors bot
added a commit
that referenced
this pull request
Feb 19, 2019
858: Use named multiline Problem Matcher r=matklad a=kjeremy Now that microsoft/vscode#65840 is in the latest release we can use the first commit from #408 Co-authored-by: kjeremy <kjeremy@gmail.com>
matklad
pushed a commit
to matklad/vscode-rust
that referenced
this pull request
Jul 13, 2020
Now that microsoft/vscode#65840 is in the latest release we can use the first commit from rust-lang/rust-analyzer#408
matklad
pushed a commit
to matklad/vscode-rust
that referenced
this pull request
Jul 13, 2020
858: Use named multiline Problem Matcher r=matklad a=kjeremy Now that microsoft/vscode#65840 is in the latest release we can use the first commit from rust-lang/rust-analyzer#408 Co-authored-by: kjeremy <kjeremy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem matcher wasn't working properly and looking at the rustc errors i realized it could be simplified.
I also added a new problem matcher that can be used with https://github.com/passcod/cargo-watch to get the errors in the editor on save. To use it one can create a tasks.json file with:
{ "version": "2.0.0", "tasks": [ { "type": "shell", "label": "cargo watch", "command": "cargo", "isBackground": true, "args": [ "watch", "-c" ], "problemMatcher": [ "$rustc-watch" ] } ] }I initially implemented it like this: cff9f62 but i think there's a bug in vscode so i worked around it by copying the pattern for both problem matchers. The first commit can be used if microsoft/vscode#65840 is merged.