restrict manual_clamp to const case, bring it out of nursery#12543
restrict manual_clamp to const case, bring it out of nursery#12543bors merged 4 commits intorust-lang:masterfrom
Conversation
rustbot
added
the
S-waiting-on-review
Xaeroxe
force-pushed
the
manual-clamp-const
branch
from
4484597 to
0cf9d9c
Compare
|
Hey @GuillaumeGomez, do you want to take a look at this PR? |
|
Sure! |
GuillaumeGomez
left a comment
GuillaumeGomez
left a comment
There was a problem hiding this comment.
Apart from my nit, lint group and code changes both look good to me.
GuillaumeGomez
left a comment
GuillaumeGomez
left a comment
There was a problem hiding this comment.
Looks good to me now, thanks!
Handing back review to @xFrednet now. ;)
xFrednet
left a comment
xFrednet
left a comment
There was a problem hiding this comment.
Two small NITs and then this should be good to go. Thank you for coming back and fixing the lint!
Also thank you to @GuillaumeGomez for the review :)
|
Looks good to me, thank you! :D @bors r=xFrednet,GuillaumeGomez |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
1 similar comment
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
|
👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request. |
5 participants
Implements the plan that I described in #9484 (comment)
This does two things primarily
manual_clampsuch that it will only trigger if we are able to guarantee thatclampwon't panic at runtime.manual_clampout of nursery status and move it into the complexity group.changelog: [
manual_clamp]: Restrict this lint such that it only triggers if max and min are const, and max is greater than or equal to min. Then bring it out of the nursery group.