Skip to content

Comments

remove HRTB from [T]::is_sorted_by{,_key}#102977

Merged
bors merged 2 commits intorust-lang:masterfrom
lukas-code:is-sorted-hrtb
Nov 19, 2022
Merged

remove HRTB from [T]::is_sorted_by{,_key}#102977
bors merged 2 commits intorust-lang:masterfrom
lukas-code:is-sorted-hrtb

Conversation

@lukas-code
Copy link
Member

@lukas-code lukas-code commented Oct 12, 2022 •
edited
Loading

Changes the signature of [T]::is_sorted_by{,_key} to match [T]::binary_search_by{,_key} and make code like #53485 (comment) compile.

Tracking issue: #53485

Do we need an ACP for something like this? Edit: Filed ACP here: rust-lang/libs-team#121

@rust-highfive
Copy link
Contributor

rust-highfive commented Oct 12, 2022

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 12, 2022
@rustbot
Copy link
Collaborator

rustbot commented Oct 12, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 12, 2022
@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Oct 16, 2022

Yes, I think an ACP or similar would make sense. Marking as waiting on libs-api.

@Mark-Simulacrum Mark-Simulacrum added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-team and removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 16, 2022
@lukas-code lukas-code mentioned this pull request Oct 17, 2022
Closed
@m-ou-se
Copy link
Member

m-ou-se commented Nov 15, 2022

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 15, 2022

📌 Commit f3d7b39 has been approved by m-ou-se

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-team labels Nov 15, 2022
@Manishearth Manishearth mentioned this pull request Nov 16, 2022
Closed
Manishearth added a commit to Manishearth/rust that referenced this pull request Nov 16, 2022
@Manishearth
Rollup merge of rust-lang#102977 - lukas-code:is-sorted-hrtb, r=m-ou-se
a396240 
remove HRTB from `[T]::is_sorted_by{,_key}`

Changes the signature of `[T]::is_sorted_by{,_key}` to match `[T]::binary_search_by{,_key}` and make code like rust-lang#53485 (comment) compile.

Tracking issue: rust-lang#53485

~~Do we need an ACP for something like this?~~ Edit: Filed ACP here: rust-lang/libs-team#121
Manishearth added a commit to Manishearth/rust that referenced this pull request Nov 18, 2022
@Manishearth
Rollup merge of rust-lang#102977 - lukas-code:is-sorted-hrtb, r=m-ou-se
43d7b73 
remove HRTB from `[T]::is_sorted_by{,_key}`

Changes the signature of `[T]::is_sorted_by{,_key}` to match `[T]::binary_search_by{,_key}` and make code like rust-lang#53485 (comment) compile.

Tracking issue: rust-lang#53485

~~Do we need an ACP for something like this?~~ Edit: Filed ACP here: rust-lang/libs-team#121
@Manishearth Manishearth mentioned this pull request Nov 18, 2022
Closed
Manishearth added a commit to Manishearth/rust that referenced this pull request Nov 18, 2022
@Manishearth
Rollup merge of rust-lang#102977 - lukas-code:is-sorted-hrtb, r=m-ou-se
c4fb7f9 
remove HRTB from `[T]::is_sorted_by{,_key}`

Changes the signature of `[T]::is_sorted_by{,_key}` to match `[T]::binary_search_by{,_key}` and make code like rust-lang#53485 (comment) compile.

Tracking issue: rust-lang#53485

~~Do we need an ACP for something like this?~~ Edit: Filed ACP here: rust-lang/libs-team#121
This was referenced Nov 18, 2022
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 18, 2022
@bors
Auto merge of rust-lang#104591 - Manishearth:rollup-b3ser4e, r=Manish…
ff0ffda 
…earth

Rollup of 8 pull requests

Successful merges:

 - rust-lang#102977 (remove HRTB from `[T]::is_sorted_by{,_key}`)
 - rust-lang#103378 (Fix mod_inv termination for the last iteration)
 - rust-lang#103456 (`unchecked_{shl|shr}` should use `u32` as the RHS)
 - rust-lang#103701 (Simplify some pointer method implementations)
 - rust-lang#104047 (Diagnostics `icu4x` based list formatting.)
 - rust-lang#104338 (Enforce that `dyn*` coercions are actually pointer-sized)
 - rust-lang#104498 (Edit docs for `rustc_errors::Handler::stash_diagnostic`)
 - rust-lang#104556 (rustdoc: use `code-header` class to format enum variants)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8aca6cc into rust-lang:master Nov 19, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 19, 2022
@lukas-code lukas-code deleted the is-sorted-hrtb branch November 19, 2022 12:38
@lukas-code
Copy link
Member Author

lukas-code commented Nov 19, 2022

since this feature is still unstable
@rustbot label -relnotes

@rustbot rustbot removed the relnotes Marks issues that should be documented in the release notes of the next release. label Nov 19, 2022
@bennyvasquez bennyvasquez mentioned this pull request Nov 24, 2022
Merged
@WaffleLapkin WaffleLapkin mentioned this pull request Sep 19, 2023
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.67.0

Development

Successfully merging this pull request may close these issues.

6 participants

@lukas-code @rust-highfive @rustbot @Mark-Simulacrum @m-ou-se @bors