Re-add rustc_codegen_ssa::builder::array_alloca#104022
Closed
Ayush1325 wants to merge 1 commit intorust-lang:masterfrom
Closed
Re-add rustc_codegen_ssa::builder::array_alloca#104022Ayush1325 wants to merge 1 commit intorust-lang:masterfrom
Ayush1325 wants to merge 1 commit intorust-lang:masterfrom
Conversation
Collaborator
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @wesleywiser (or someone else) soon. Please see the contribution instructions for more information. |
rustbot
added
S-waiting-on-review
Collaborator
|
Some changes occurred in compiler/rustc_codegen_gcc cc @antoyo |
This function was removed in the rust-lang#102551 I need this function in rust-lang#100316 for the custom entry function for UEFI. Signed-off-by: Ayush Singh <ayushsingh1325@gmail.com>
Ayush1325
force-pushed
the
array_alloca
branch
from
35cbc2b to
69af784
Compare
Contributor
|
From a brief glance to #100316, this looks unnecessary. Array allocas are non-canonical and only needed if the alloca is dynamically sized, which does not appear to be the case here. You can create a standard |
Contributor
Author
Thanks. When you mean standard bx.alloca(cx.type_array(cx.type_i8p(), bx.const_int(cx.type_int(), 2)), Align::ONE); |
Contributor
|
It's probably just |
Ayush1325
added a commit
to Ayush1325/rust
that referenced
this pull request
Nov 6, 2022
Moved type_array function to rustc_codegen_ssa::BaseTypeMethods trait. This allows using normal alloca function to create arrays as suggested in rust-lang#104022. Signed-off-by: Ayush Singh <ayushsingh1325@gmail.com>
JohnTitor
pushed a commit
to JohnTitor/rust
that referenced
this pull request
Nov 6, 2022
Add type_array to BaseTypeMethods Moved `type_array` function to `rustc_codegen_ssa::BaseTypeMethods` trait. This allows using normal `alloca` function to create arrays as suggested in rust-lang#104022. Signed-off-by: Ayush Singh <ayushsingh1325@gmail.com>
JohnTitor
pushed a commit
to JohnTitor/rust
that referenced
this pull request
Nov 7, 2022
Add type_array to BaseTypeMethods Moved `type_array` function to `rustc_codegen_ssa::BaseTypeMethods` trait. This allows using normal `alloca` function to create arrays as suggested in rust-lang#104022. Signed-off-by: Ayush Singh <ayushsingh1325@gmail.com>
antoyo
pushed a commit
to rust-lang/rustc_codegen_gcc
that referenced
this pull request
Mar 1, 2023
Moved type_array function to rustc_codegen_ssa::BaseTypeMethods trait. This allows using normal alloca function to create arrays as suggested in rust-lang/rust#104022. Signed-off-by: Ayush Singh <ayushsingh1325@gmail.com>
antoyo
pushed a commit
to rust-lang/rustc_codegen_gcc
that referenced
this pull request
Jun 3, 2023
Moved type_array function to rustc_codegen_ssa::BaseTypeMethods trait. This allows using normal alloca function to create arrays as suggested in rust-lang/rust#104022. Signed-off-by: Ayush Singh <ayushsingh1325@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function was removed in the #102551
I need this function in #100316 for the custom entry function for UEFI.
Signed-off-by: Ayush Singh ayushsingh1325@gmail.com