Conversation
rustbot
added
S-waiting-on-review
matthiaskrgr
commented
Dec 12, 2022
Comment on lines
9
to
13
| pub const ALPHANUMERIC_ONLY: usize = 62; | ||
| pub const CASE_INSENSITIVE: usize = 36; | ||
|
|
||
| const BASE_64: &[u8; MAX_BASE as usize] = | ||
| const BASE_64: &[u8; MAX_BASE] = | ||
| b"0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ@$"; |
Member
Author
There was a problem hiding this comment.
MAX_BASE is already declared usize at line 8
| // And all trailing bits (i.e. from 0..=end) in the end word, | ||
| // including the end. | ||
| self.words[end_word_index] |= end_mask | end_mask - 1; | ||
| self.words[end_word_index] |= end_mask | (end_mask - 1); |
Contributor
There was a problem hiding this comment.
lol was this a bug? or is the precedence alright implicitly like those parens?
Member
Author
There was a problem hiding this comment.
according to clippy the precedence was already like this but since its no obvious it suggested the parens 🙃
Contributor
|
@bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 13, 2022
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#104864 (Account for item-local in inner scope for E0425) - rust-lang#105332 (Point out the type of associated types in every method call of iterator chains) - rust-lang#105620 (Remove unnecessary uses of `clone`) - rust-lang#105625 (minor code cleanups) - rust-lang#105629 (rustdoc: stop treating everything in a trait item as a method) - rust-lang#105636 (Add check for local-storage value when changing "display line numbers" settings) - rust-lang#105639 (rustdoc: remove `type="text/css" from stylesheet links) - rust-lang#105640 (Adjust miri to still be optional) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @compiler-errors