Skip to content

Suggest impl Fn* and impl Future in -> _ return suggestions#106200

Merged
bors merged 2 commits intorust-lang:masterfrom
compiler-errors:suggest-impl-trait
Jan 4, 2023
Merged

Suggest impl Fn* and impl Future in -> _ return suggestions#106200
bors merged 2 commits intorust-lang:masterfrom
compiler-errors:suggest-impl-trait

Conversation

@compiler-errors
Copy link
Contributor

@compiler-errors compiler-errors commented Dec 28, 2022

Follow-up to #106172, only the last commit is relevant. Can rebase once that PR is landed for easier review.

Suggests impl Future and impl Fn{,Mut,Once} in -> _ return suggestions.

r? @estebank

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 28, 2022
@rustbot
Copy link
Collaborator

rustbot commented Dec 28, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

estebank
estebank approved these changes Dec 28, 2022
View reviewed changes
Copy link
Contributor

@estebank estebank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@estebank
Copy link
Contributor

estebank commented Dec 28, 2022

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 28, 2022

📌 Commit 0232387249d6925cb407d9eb85193bf1e5b88c90 has been approved by estebank

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 28, 2022
@estebank
Copy link
Contributor

estebank commented Dec 28, 2022

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 28, 2022
@compiler-errors
Copy link
Contributor Author

compiler-errors commented Dec 30, 2022

The other PR landed, rebased

@bors r=estebank

@bors
Copy link
Collaborator

bors commented Dec 30, 2022

📌 Commit 8a7d62021b2d79565f4db2fe23bfcd27a9600f6c has been approved by estebank

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 30, 2022
estebank
estebank reviewed Dec 30, 2022
View reviewed changes
estebank
estebank reviewed Dec 30, 2022
View reviewed changes
@compiler-errors
Copy link
Contributor Author

compiler-errors commented Dec 30, 2022

@bors r- i'll address the note comment

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 30, 2022
@compiler-errors
Copy link
Contributor Author

compiler-errors commented Jan 4, 2023

Added the note back.

@bors r=estebank

@bors
Copy link
Collaborator

bors commented Jan 4, 2023

📌 Commit 89086f7 has been approved by estebank

It is now in the queue for this repository.

@bors bors removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 4, 2023
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 4, 2023
@compiler-errors
Copy link
Contributor Author

compiler-errors commented Jan 4, 2023

Only on error path @bors rollup

@matthiaskrgr matthiaskrgr mentioned this pull request Jan 4, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 4, 2023
@bors
Auto merge of rust-lang#106442 - matthiaskrgr:rollup-wivf7gh, r=matth…
5c18bc6 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#106200 (Suggest `impl Fn*` and `impl Future` in `-> _` return suggestions)
 - rust-lang#106274 (Add JSON output to -Zdump-mono-stats)
 - rust-lang#106292 (Add codegen test for `Box::new(uninit)` of big arrays)
 - rust-lang#106327 (Add tidy check for dbg)
 - rust-lang#106361 (Note maximum integer literal for `IntLiteralTooLarge`)
 - rust-lang#106396 (Allow passing a specific date to `bump-stage0`)
 - rust-lang#106436 (Enable doctests for rustc_query_impl)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 70468af into rust-lang:master Jan 4, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 4, 2023
@lukas-code lukas-code mentioned this pull request Jan 19, 2023
Closed
4 tasks
@compiler-errors compiler-errors deleted the suggest-impl-trait branch August 11, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estebank estebank estebank approved these changes

Assignees

@estebank estebank

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.68.0

Development

Successfully merging this pull request may close these issues.

4 participants

@compiler-errors @rustbot @estebank @bors