Correct detection of elided lifetimes in impl-trait.#106501
Merged
bors merged 1 commit intorust-lang:masterfrom Jan 6, 2023
Merged
Correct detection of elided lifetimes in impl-trait.#106501bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
rustbot
added
S-waiting-on-review
compiler-errors
added
the
beta-nominated
Contributor
|
Makes sense. @bors r+ |
Collaborator
bors
added
S-waiting-on-bors
pnkfelix
reviewed
Jan 5, 2023
| && let hir::LifetimeName::Param(param_id) = lifetime_ref.res | ||
| && let Some(generics) = self.tcx.hir().get_generics(self.tcx.local_parent(param_id)) | ||
| && let Some(param) = generics.params.iter().find(|p| p.def_id == param_id) | ||
| && param.is_elided_lifetime() |
Contributor
There was a problem hiding this comment.
With this PR, the error message still reads as ""anonymous lifetimes in impl Trait are unstable"
should it change to "elided lifetimes" instead of "anonymous lifetimes"?
Contributor
There was a problem hiding this comment.
(this feedback need not block the landing of this PR. It was just something I noticed while looking it over)
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
Finished benchmarking commit (0fb8b72): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
Contributor
rustbot
added
the
beta-accepted
Mark-Simulacrum
removed
the
beta-nominated
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 20, 2023
…mulacrum [beta] backport rollup * Revert "Make nested RPITIT inherit the parent opaque's generics." rust-lang#106759 * Fix mpsc::SyncSender spinning behavior rust-lang#106701 * rustdoc: fix outdated lint section of the book rust-lang#106605 * Do not filter substs in remap_generic_params_to_declaration_params. rust-lang#106503 * Correct detection of elided lifetimes in impl-trait. rust-lang#106501 * Bump rust-installer rust-lang#106196 * Don't panic on stable since miri is not available there rust-lang#105901
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #106338
r? @compiler-errors
cc @pnkfelix