Skip to content

Remove public doc(hidden) core::fmt::rt::v1#110616

Merged
bors merged 8 commits intorust-lang:masterfrom
m-ou-se:fmt-lang-items
Apr 20, 2023
Merged

Remove public doc(hidden) core::fmt::rt::v1#110616
bors merged 8 commits intorust-lang:masterfrom
m-ou-se:fmt-lang-items

Conversation

@m-ou-se
Copy link
Member

@m-ou-se m-ou-se commented Apr 20, 2023 •
edited
Loading

All the types used by format_arg!() are now lang items, so they are no longer required as publicly exported items.

Part of #99012

After this change, the rt module is private, and contains only three lang items used by format_args (Placeholder, Alignment, and Count): https://github.com/rust-lang/rust/blob/441682cca9a32314835a88fa981a3bf13ffb0aa8/library/core/src/fmt/rt.rs

@m-ou-se m-ou-se added C-cleanup Category: PRs that clean code up or issues documenting cleanup. A-fmt Area: `core::fmt` labels Apr 20, 2023
@rustbot
Copy link
Collaborator

rustbot commented Apr 20, 2023

r? @thomcc

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 20, 2023
@rustbot

This comment was marked as resolved.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot

This comment was marked as outdated.

Sign in to view
jyn514
jyn514 approved these changes Apr 20, 2023
View reviewed changes
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with or without the nit fixed

@m-ou-se @jyn514
Add reason to #![unstable] tag.
bd917bb 
Co-authored-by: jyn <github@jyn.dev>
@m-ou-se
Copy link
Member Author

m-ou-se commented Apr 20, 2023

@bors r=jyn514

@bors
Copy link
Collaborator

bors commented Apr 20, 2023

📌 Commit bd917bb has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 20, 2023
@m-ou-se
Copy link
Member Author

m-ou-se commented Apr 20, 2023

@bors rollup=never

Just in case this breaks tooling or something, so it's easier to trace issues back to this PR.

@bors
Copy link
Collaborator

bors commented Apr 20, 2023

⌛ Testing commit bd917bb with merge 8bdcc62...

@bors
Copy link
Collaborator

bors commented Apr 20, 2023

☀️ Test successful - checks-actions
Approved by: jyn514
Pushing 8bdcc62 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 20, 2023
@bors bors merged commit 8bdcc62 into rust-lang:master Apr 20, 2023
@rustbot rustbot added this to the 1.71.0 milestone Apr 20, 2023
@rust-timer
Copy link
Collaborator

rust-timer commented Apr 21, 2023

Finished benchmarking commit (8bdcc62): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 3.6% [3.6%, 3.6%] 1
Regressions ❌
(secondary)		 2.8% [2.8%, 2.8%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -3.7% [-3.7%, -3.7%] 1
All ❌✅ (primary) 3.6% [3.6%, 3.6%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

@m-ou-se m-ou-se deleted the fmt-lang-items branch April 21, 2023 12:45
This was referenced Apr 24, 2023
Merged
Open
@Noratrieb Noratrieb mentioned this pull request Apr 26, 2023
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 28, 2023
@matthiaskrgr
Rollup merge of rust-lang#110766 - m-ou-se:fmt-rt, r=jyn514
cf911ac 
More core::fmt::rt cleanup.

- Removes the `V1` suffix from the `Argument` and `Flag` types.

- Moves more of the format_args lang items into the `core::fmt::rt` module. (The only remaining lang item in `core::fmt` is `Arguments` itself, which is a public type.)

Part of rust-lang#99012

Follow-up to rust-lang#110616
RalfJung pushed a commit to RalfJung/miri that referenced this pull request Apr 28, 2023
@matthiaskrgr
Rollup merge of #110766 - m-ou-se:fmt-rt, r=jyn514
6263ff9 
More core::fmt::rt cleanup.

- Removes the `V1` suffix from the `Argument` and `Flag` types.

- Moves more of the format_args lang items into the `core::fmt::rt` module. (The only remaining lang item in `core::fmt` is `Arguments` itself, which is a public type.)

Part of rust-lang/rust#99012

Follow-up to rust-lang/rust#110616
lnicola pushed a commit to lnicola/rust-analyzer that referenced this pull request May 9, 2023
@matthiaskrgr
Rollup merge of #110766 - m-ou-se:fmt-rt, r=jyn514
e99a990 
More core::fmt::rt cleanup.

- Removes the `V1` suffix from the `Argument` and `Flag` types.

- Moves more of the format_args lang items into the `core::fmt::rt` module. (The only remaining lang item in `core::fmt` is `Arguments` itself, which is a public type.)

Part of rust-lang/rust#99012

Follow-up to rust-lang/rust#110616
thomcc pushed a commit to tcdi/postgrestd that referenced this pull request Jul 18, 2023
@matthiaskrgr
Rollup merge of #110766 - m-ou-se:fmt-rt, r=jyn514
7475043 
More core::fmt::rt cleanup.

- Removes the `V1` suffix from the `Argument` and `Flag` types.

- Moves more of the format_args lang items into the `core::fmt::rt` module. (The only remaining lang item in `core::fmt` is `Arguments` itself, which is a public type.)

Part of rust-lang/rust#99012

Follow-up to rust-lang/rust#110616
@apiraino apiraino mentioned this pull request Oct 11, 2023
Closed
RalfJung pushed a commit to RalfJung/rust-analyzer that referenced this pull request Apr 20, 2024
@matthiaskrgr
Rollup merge of #110766 - m-ou-se:fmt-rt, r=jyn514
ff11ba3 
More core::fmt::rt cleanup.

- Removes the `V1` suffix from the `Argument` and `Flag` types.

- Moves more of the format_args lang items into the `core::fmt::rt` module. (The only remaining lang item in `core::fmt` is `Arguments` itself, which is a public type.)

Part of rust-lang/rust#99012

Follow-up to rust-lang/rust#110616
RalfJung pushed a commit to RalfJung/rust-analyzer that referenced this pull request Apr 27, 2024
@matthiaskrgr
Rollup merge of #110766 - m-ou-se:fmt-rt, r=jyn514
be63682 
More core::fmt::rt cleanup.

- Removes the `V1` suffix from the `Argument` and `Flag` types.

- Moves more of the format_args lang items into the `core::fmt::rt` module. (The only remaining lang item in `core::fmt` is `Arguments` itself, which is a public type.)

Part of rust-lang/rust#99012

Follow-up to rust-lang/rust#110616
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jyn514 jyn514 jyn514 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@thomcc thomcc

Labels

A-fmt Area: `core::fmt` C-cleanup Category: PRs that clean code up or issues documenting cleanup. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.71.0

Development

Successfully merging this pull request may close these issues.

7 participants

@m-ou-se @rustbot @rust-log-analyzer @bors @rust-timer @jyn514 @thomcc

Comments