remove_dir_all: try deleting the directory even if FILE_LIST_DIRECTORY access is denied#110918
Merged
bors merged 1 commit intorust-lang:masterfrom Apr 28, 2023
Merged
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
Member
Author
|
Hm, the diff is quite a bit larger than the actual changes as it affects some indentation. The important bit is that it allows failing to opening the directory with traverse access and falls back to treating like any other file. |
This comment has been minimized.
This comment has been minimized.
If opening a directory with `FILE_LIST_DIRECTORY` access fails then we should try opening without requesting that access. We may still be able to delete it if it's empty or a link.
ChrisDenton
force-pushed
the
on-error-resume-next
branch
from
b3766d4 to
ddff7f0
Compare
ChrisDenton
changed the title
remove_dir_all: try deleting the directory even if FILE_LIST_DIRECTORY access is denied
Member
|
Looks simple enough to me! @bors r+ |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 28, 2023
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#110766 (More core::fmt::rt cleanup.) - rust-lang#110873 (Migrate trivially translatable `rustc_parse` diagnostics) - rust-lang#110904 (rustdoc: rebind bound vars to type-outlives predicates) - rust-lang#110913 (Add some missing built-in lints) - rust-lang#110918 (`remove_dir_all`: try deleting the directory even if `FILE_LIST_DIRECTORY` access is denied) - rust-lang#110920 (Fix unavailable url) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If opening a directory with
FILE_LIST_DIRECTORYaccess fails then we should try opening without requesting that access. We may still be able to delete it if it's empty or a link.Fixes rust-lang/cargo#12042