fixed *const [type error] does not implement the Copy trait#114752
Merged
bors merged 1 commit intorust-lang:masterfrom Aug 14, 2023
Merged
fixed *const [type error] does not implement the Copy trait#114752bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
Collaborator
|
r? @jackh726 (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
fee1-dead
reviewed
Aug 12, 2023
Contributor
|
This should include tests that make sure that the issue is fixed, and that this doesn't regress. |
Member
|
See comments above |
jackh726
added
S-waiting-on-author
Contributor
Author
I have the code in the original issue as a test case. I'd like to know what other test cases I could add to this PR and how to write them up. |
This comment has been minimized.
This comment has been minimized.
Contributor
|
Can you squash this into one commit please? Usually for things like this where you're fixing nits and making it pass, there's no reason to maintain commit history 😸 |
RickleAndMortimer
force-pushed
the
issue-113788-fix
branch
from
afa5539 to
468559a
Compare
fee1-dead
reviewed
Aug 14, 2023
src/llvm-project
Outdated
Member
There was a problem hiding this comment.
This submodule update doesn't seem to be right.
RickleAndMortimer
force-pushed
the
issue-113788-fix
branch
from
468559a to
cac7c12
Compare
compiler-errors
approved these changes
Aug 14, 2023
Contributor
|
@bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
Contributor
Author
|
Thank you @compiler-errors @jackh726 @asquared31415 @fee1-dead for your feedback! |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 14, 2023
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#114745 (Make Const more useful in smir) - rust-lang#114752 (fixed *const [type error] does not implement the Copy trait) - rust-lang#114760 (DebugInfo: Updates test cases that add method declarations.) - rust-lang#114815 (Update books) - rust-lang#114817 (Remove unnecessary FIXME) r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes "error: arguments for inline assembly must be copyable" when moving an unknown type
Fixes: #113788