Skip to content

Comments

doc: update lld-flavor ref#114923

Merged
bors merged 1 commit intorust-lang:masterfrom
cuishuang:master
Aug 29, 2023
Merged

doc: update lld-flavor ref#114923
bors merged 1 commit intorust-lang:masterfrom
cuishuang:master

Conversation

@cuishuang
Copy link
Contributor

@cuishuang cuishuang commented Aug 17, 2023

No description provided.

@cuishuang
doc: update lld-flavor ref
6354e06 
Signed-off-by: cui fliter <imcusg@gmail.com>
@rustbot
Copy link
Collaborator

rustbot commented Aug 17, 2023

r? @GuillaumeGomez

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 17, 2023
@rust-log-analyzer
Copy link
Collaborator

rust-log-analyzer commented Aug 17, 2023

The job mingw-check-tidy failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
Prepare all required actions
Getting action download info
Download action repository 'actions/checkout@v3' (SHA:c85c95e3d7251135ab7dc9ce3241c5835cc595a9)
Download action repository 'actions/upload-artifact@v3' (SHA:0b7f8abb1508181956e8e162db84b466c27e18ce)
Complete job name: PR - mingw-check-tidy
git config --global core.autocrlf false
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
---
GITHUB_ACTION=__run_7
GITHUB_ACTIONS=true
GITHUB_ACTION_REF=
GITHUB_ACTION_REPOSITORY=
GITHUB_ACTOR=cuishuang
GITHUB_API_URL=https://api.github.com
GITHUB_BASE_REF=master
GITHUB_ENV=/home/runner/work/_temp/_runner_file_commands/set_env_dd457958-567e-4fa4-9f9f-96b091f4d1a8
GITHUB_EVENT_NAME=pull_request
---
GITHUB_SERVER_URL=https://github.com
GITHUB_SHA=169100c95f8ca1324116637f95e46de090d59288
GITHUB_STATE=/home/runner/work/_temp/_runner_file_commands/save_state_dd457958-567e-4fa4-9f9f-96b091f4d1a8
GITHUB_STEP_SUMMARY=/home/runner/work/_temp/_runner_file_commands/step_summary_dd457958-567e-4fa4-9f9f-96b091f4d1a8
GITHUB_TRIGGERING_ACTOR=cuishuang
GITHUB_WORKFLOW_REF=rust-lang/rust/.github/workflows/ci.yml@refs/pull/114923/merge
GITHUB_WORKFLOW_SHA=169100c95f8ca1324116637f95e46de090d59288
GITHUB_WORKSPACE=/home/runner/work/rust/rust
GOROOT_1_18_X64=/opt/hostedtoolcache/go/1.18.10/x64
---
Removing intermediate container 55800a3ae53a
 ---> f9197d91bcaa
Step 6/10 : COPY host-x86_64/mingw-check/reuse-requirements.txt /tmp/
 ---> 0c23f8cf6f16
Step 7/10 : RUN pip3 install --no-deps --no-cache-dir --require-hashes -r /tmp/reuse-requirements.txt     && pip3 install virtualenv
Collecting binaryornot==0.4.4
  Downloading binaryornot-0.4.4-py2.py3-none-any.whl (9.0 kB)
Collecting boolean-py==4.0
  Downloading boolean.py-4.0-py3-none-any.whl (25 kB)
---
Building wheels for collected packages: reuse
  Building wheel for reuse (pyproject.toml): started
  Building wheel for reuse (pyproject.toml): finished with status 'done'
  Created wheel for reuse: filename=reuse-1.1.0-cp310-cp310-manylinux_2_35_x86_64.whl size=180116 sha256=351235b2326fb4db7a18e257e13ce7896c5f77339521e2c2612e71e154800a19
  Stored in directory: /tmp/pip-ephem-wheel-cache-0elazdj7/wheels/c2/3c/b9/1120c2ab4bd82694f7e6f0537dc5b9a085c13e2c69a8d0c76d
Installing collected packages: boolean-py, binaryornot, setuptools, reuse, python-debian, markupsafe, license-expression, jinja2, chardet
  Attempting uninstall: setuptools
    Found existing installation: setuptools 59.6.0
    Not uninstalling setuptools at /usr/lib/python3/dist-packages, outside environment /usr
    Not uninstalling setuptools at /usr/lib/python3/dist-packages, outside environment /usr
    Can't uninstall 'setuptools'. No files were found to uninstall.
Successfully installed binaryornot-0.4.4 boolean-py-4.0 chardet-5.1.0 jinja2-3.1.2 license-expression-30.0.0 markupsafe-2.1.1 python-debian-0.1.49 reuse-1.1.0 setuptools-66.0.0
WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
Collecting virtualenv
  Downloading virtualenv-20.24.3-py3-none-any.whl (3.0 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 3.0/3.0 MB 52.2 MB/s eta 0:00:00
Collecting distlib<1,>=0.3.7
  Downloading distlib-0.3.7-py2.py3-none-any.whl (468 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 468.9/468.9 KB 119.9 MB/s eta 0:00:00
Collecting platformdirs<4,>=3.9.1
  Downloading platformdirs-3.10.0-py3-none-any.whl (17 kB)
Collecting filelock<4,>=3.12.2
  Downloading filelock-3.12.2-py3-none-any.whl (10 kB)
Installing collected packages: distlib, platformdirs, filelock, virtualenv
Successfully installed distlib-0.3.7 filelock-3.12.2 platformdirs-3.10.0 virtualenv-20.24.3
Removing intermediate container a6d2fdb51b68
 ---> 6d957c912f18
Step 8/10 : COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/
 ---> 6e506e02937a
 ---> 6e506e02937a
Step 9/10 : COPY host-x86_64/mingw-check/validate-error-codes.sh /scripts/
 ---> fbc59b0efce8
Step 10/10 : ENV SCRIPT TIDY_PRINT_DIFF=1 python2.7 ../x.py test            --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint
Removing intermediate container a4349c66ae66
 ---> 01a5f4374011
Successfully built 01a5f4374011
Successfully tagged rust-ci:latest
Successfully tagged rust-ci:latest
##[endgroup]
Built container sha256:01a5f4374011e4936b0566c81142c433eb81a13d222fab5405b10a70f17728dd
Uploading finished image to https://ci-caches.rust-lang.org/docker/f76604104d6a6f4aa068dca8679411c51198f6c5562033174b89cf3ceb2f9ecc175231f1257b18e00fa57bb3eed5f53dbcc121e55de0452dda3db18894e27ea0

<botocore.awsrequest.AWSRequest object at 0x7f2bf707f7d0>
gzip: stdout: Broken pipe
xargs: docker: terminated by signal 13
[CI_JOB_NAME=mingw-check-tidy]
[CI_JOB_NAME=mingw-check-tidy]
---
DirectMap4k:      266176 kB
DirectMap2M:    10219520 kB
DirectMap1G:     8388608 kB
##[endgroup]
Executing TIDY_PRINT_DIFF=1 python2.7 ../x.py test            --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint
+ TIDY_PRINT_DIFF=1 python2.7 ../x.py test --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint
    Finished dev [unoptimized] target(s) in 0.03s
##[endgroup]
downloading https://ci-artifacts.rust-lang.org/rustc-builds-alt/c5833f1956bea474034ffec5ab2c75f343548038/rust-dev-nightly-x86_64-unknown-linux-gnu.tar.xz
extracting /checkout/obj/build/cache/llvm-c5833f1956bea474034ffec5ab2c75f343548038-true/rust-dev-nightly-x86_64-unknown-linux-gnu.tar.xz to /checkout/obj/build/x86_64-unknown-linux-gnu/ci-llvm
extracting /checkout/obj/build/cache/llvm-c5833f1956bea474034ffec5ab2c75f343548038-true/rust-dev-nightly-x86_64-unknown-linux-gnu.tar.xz to /checkout/obj/build/x86_64-unknown-linux-gnu/ci-llvm
##[group]Building stage0 tool tidy (x86_64-unknown-linux-gnu)
    Updating crates.io index
warning: spurious network error (3 tries remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (2 tries remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 tries remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
error: failed to get `zerofrom-derive` as a dependency of package `zerofrom v0.1.2`
    ... which satisfies dependency `zerofrom = "^0.1.1"` (locked to 0.1.2) of package `icu_provider v1.2.0`
    ... which satisfies dependency `icu_provider = "^1.2.0"` (locked to 1.2.0) of package `icu_list v1.2.0`
    ... which satisfies dependency `icu_list = "^1.2"` (locked to 1.2.0) of package `rustc_baked_icu_data v0.0.0 (/checkout/compiler/rustc_baked_icu_data)`
    ... which satisfies path dependency `rustc_baked_icu_data` (locked to 0.0.0) of package `rustc_error_messages v0.0.0 (/checkout/compiler/rustc_error_messages)`
    ... which satisfies path dependency `rustc_error_messages` (locked to 0.0.0) of package `rustc_driver_impl v0.0.0 (/checkout/compiler/rustc_driver_impl)`
    ... which satisfies path dependency `rustc_driver_impl` (locked to 0.0.0) of package `rustc-main v0.0.0 (/checkout/compiler/rustc)`
Caused by:
  failed to query replaced source registry `crates-io`

Caused by:
Caused by:
  download of ze/ro/zerofrom-derive failed
Caused by:
Caused by:
  failed to download from `https://index.crates.io/ze/ro/zerofrom-derive`
Caused by:
  [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
Build completed unsuccessfully in 0:02:20
  local time: Thu Aug 17 07:17:50 UTC 2023

@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Aug 17, 2023

r? rust-lang/compiler

@rustbot rustbot assigned fee1-dead and unassigned GuillaumeGomez Aug 17, 2023
@fee1-dead
Copy link
Member

fee1-dead commented Aug 17, 2023

r? compiler

@rustbot rustbot assigned TaKO8Ki and unassigned fee1-dead Aug 17, 2023
@cuishuang
Copy link
Contributor Author

cuishuang commented Aug 19, 2023

friendly ping~

@cuishuang
Copy link
Contributor Author

cuishuang commented Aug 19, 2023

r? compiler

@rustbot rustbot assigned wesleywiser and unassigned TaKO8Ki Aug 19, 2023
klensy
klensy reviewed Aug 19, 2023
View reviewed changes
wesleywiser
wesleywiser approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@wesleywiser wesleywiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cuishuang! I looked briefly to see if there was a non-MachO specific page detailing linker flavors we could link to but couldn't find one. Since the page is the same one we had before, just with a fixed url, I don't see any reason to hold this change up on that.

@wesleywiser
Copy link
Member

wesleywiser commented Aug 29, 2023

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 29, 2023

📌 Commit 6354e06 has been approved by wesleywiser

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 29, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 29, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 29, 2023
@bors
Auto merge of rust-lang#115354 - matthiaskrgr:rollup-4cotcxz, r=matth…
83995f3 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#111580 (Don't ICE on layout computation failure)
 - rust-lang#114923 (doc: update lld-flavor ref)
 - rust-lang#115174 (tests: add test for rust-lang#67992)
 - rust-lang#115187 (Add new interface to smir)
 - rust-lang#115300 (Tweaks and improvements on SMIR around generics_of and predicates_of)
 - rust-lang#115340 (some more is_zst that should be is_1zst)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 2dfb67b into rust-lang:master Aug 29, 2023
@rustbot rustbot added this to the 1.74.0 milestone Aug 29, 2023
@cuishuang
Copy link
Contributor Author

cuishuang commented Aug 30, 2023

Thanks @cuishuang! I looked briefly to see if there was a non-MachO specific page detailing linker flavors we could link to but couldn't find one. Since the page is the same one we had before, just with a fixed url, I don't see any reason to hold this change up on that.

Thanks for your detailed answer！

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wesleywiser wesleywiser wesleywiser approved these changes

+1 more reviewer

@klensy klensy klensy left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@wesleywiser wesleywiser

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.74.0

Development

Successfully merging this pull request may close these issues.

9 participants

@cuishuang @rustbot @rust-log-analyzer @GuillaumeGomez @fee1-dead @wesleywiser @bors @klensy @TaKO8Ki