Add Exploit Mitigations PG to triagebot.toml#122429
Merged
bors merged 1 commit intorust-lang:masterfrom Mar 14, 2024
Merged
Conversation
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use r? to explicitly pick a reviewer |
rustbot
added
the
A-meta
Collaborator
|
|
rustbot
added
the
S-waiting-on-review
rcvalle
force-pushed
the
rust-triagebot-add-exploit-mitigations-pg
branch
from
221f959 to
0e0888b
Compare
triagebot.toml
Outdated
| cc = ["@nnethercote"] | ||
|
|
||
| [mentions."compiler/rustc_symbol_mangling/src/typeid"] | ||
| cc = ["@project-exploit-mitigations", "@rcvalle"] |
Contributor
There was a problem hiding this comment.
This won't function the way you expect it will, since @project-exploit-mitigations is not a valid github @ -- it should be written like @rust-lang/project-exploit-mitigations.
Contributor
There was a problem hiding this comment.
Also, why are you pinging yourself explicitly? You should be pinged as a member of the group.
Member
Author
There was a problem hiding this comment.
Fixed. Thanks for pointing it out! I'm listing myself there explicitly for when the project group finishes the work (since it's temporary), I'd like to continue to be pinged, but let me know if you prefer me to remove it.
Contributor
There was a problem hiding this comment.
I don't see any fixed having been made
rcvalle
force-pushed
the
rust-triagebot-add-exploit-mitigations-pg
branch
2 times, most recently
from
2aaf445 to
b878ad2
Compare
triagebot.toml
Outdated
| cc = ["@nnethercote"] | ||
|
|
||
| [mentions."compiler/rustc_symbol_mangling/src/typeid"] | ||
| cc = [" @rust-lang/project-exploit-mitigations", "@rcvalle"] |
Contributor
There was a problem hiding this comment.
Suggested change
| cc = [" @rust-lang/project-exploit-mitigations", "@rcvalle"] | |
| cc = ["@rust-lang/project-exploit-mitigations", "@rcvalle"] |
There's a space here 😅
Member
Author
There was a problem hiding this comment.
Fixed 😅. Thanks a lot, Michael!
Add autolabels and mentions for the Exploit Mitigations PG to triagebot.toml.
rcvalle
force-pushed
the
rust-triagebot-add-exploit-mitigations-pg
branch
from
b878ad2 to
533ddf9
Compare
wesleywiser
approved these changes
Mar 13, 2024
Member
|
@bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 13, 2024
…iaskrgr Rollup of 11 pull requests Successful merges: - rust-lang#122422 (compiletest: Allow `only-unix` in test headers) - rust-lang#122424 (fix: typos) - rust-lang#122425 (Increase timeout for new bors bot) - rust-lang#122426 (Fix StableMIR `WrappingRange::is_full` computation) - rust-lang#122429 (Add Exploit Mitigations PG to triagebot.toml) - rust-lang#122430 (Generate link to `Local` in `hir::Let` documentation) - rust-lang#122434 (pattern analysis: rename a few types) - rust-lang#122437 (pattern analysis: remove `MaybeInfiniteInt::JustAfterMax`) - rust-lang#122438 (Safe Transmute: Require that source referent is smaller than destination) - rust-lang#122442 (extend docs of -Zprint-mono-items) - rust-lang#122449 (Delay a bug for stranded opaques) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 14, 2024
…iaskrgr Rollup of 11 pull requests Successful merges: - rust-lang#122422 (compiletest: Allow `only-unix` in test headers) - rust-lang#122424 (fix: typos) - rust-lang#122425 (Increase timeout for new bors bot) - rust-lang#122426 (Fix StableMIR `WrappingRange::is_full` computation) - rust-lang#122429 (Add Exploit Mitigations PG to triagebot.toml) - rust-lang#122430 (Generate link to `Local` in `hir::Let` documentation) - rust-lang#122434 (pattern analysis: rename a few types) - rust-lang#122437 (pattern analysis: remove `MaybeInfiniteInt::JustAfterMax`) - rust-lang#122438 (Safe Transmute: Require that source referent is smaller than destination) - rust-lang#122442 (extend docs of -Zprint-mono-items) - rust-lang#122449 (Delay a bug for stranded opaques) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 14, 2024
Rollup merge of rust-lang#122429 - rcvalle:rust-triagebot-add-exploit-mitigations-pg, r=wesleywiser Add Exploit Mitigations PG to triagebot.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.