Skip to content

Comments

Ungate the UNKNOWN_OR_MALFORMED_DIAGNOSTIC_ATTRIBUTES lint#122482

Merged
bors merged 1 commit intorust-lang:masterfrom
weiznich:fix/122446
Mar 14, 2024
Merged

Ungate the UNKNOWN_OR_MALFORMED_DIAGNOSTIC_ATTRIBUTES lint#122482
bors merged 1 commit intorust-lang:masterfrom
weiznich:fix/122446

Conversation

@weiznich
Copy link
Contributor

@weiznich weiznich commented Mar 14, 2024

This was missed during stablisation of the #[diagnostic] attribute namespace.

Fixes #122446

@weiznich
Ungate the UNKNOWN_OR_MALFORMED_DIAGNOSTIC_ATTRIBUTES lint
2541111 
This was missed during stablisation of the `#[diagnostic]` attribute
namespace.

Fixes rust-lang#122446
@rustbot
Copy link
Collaborator

rustbot commented Mar 14, 2024

r? @TaKO8Ki

rustbot has assigned @TaKO8Ki.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 14, 2024
@weiznich weiznich mentioned this pull request Mar 14, 2024
Closed
@compiler-errors
Copy link
Contributor

compiler-errors commented Mar 14, 2024

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Mar 14, 2024

📌 Commit 2541111 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 14, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 14, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 14, 2024
@bors
Auto merge of rust-lang#122497 - matthiaskrgr:rollup-pg9ux4r, r=matth…
30f74ff 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#119029 (Avoid closing invalid handles)
 - rust-lang#122238 (Document some builtin impls in the next solver)
 - rust-lang#122247 (rustdoc-search: depth limit `T<U>` -> `U` unboxing)
 - rust-lang#122287 (add test ensuring simd codegen checks don't run when a static assertion failed)
 - rust-lang#122368 (chore: remove repetitive words)
 - rust-lang#122397 (Various cleanups around the const eval query providers)
 - rust-lang#122406 (Fix WF for `AsyncFnKindHelper` in new trait solver)
 - rust-lang#122477 (Change some attribute to only_local)
 - rust-lang#122482 (Ungate the `UNKNOWN_OR_MALFORMED_DIAGNOSTIC_ATTRIBUTES` lint)
 - rust-lang#122490 (Update build instructions for OpenHarmony)

Failed merges:

 - rust-lang#122471 (preserve span when evaluating mir::ConstOperand)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c0fd2db into rust-lang:master Mar 14, 2024
@rustbot rustbot added this to the 1.78.0 milestone Mar 14, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 14, 2024
@rust-timer
Unrolled build for rust-lang#122482
4c41b78 
Rollup merge of rust-lang#122482 - weiznich:fix/122446, r=compiler-errors

Ungate the `UNKNOWN_OR_MALFORMED_DIAGNOSTIC_ATTRIBUTES` lint

This was missed during stablisation of the `#[diagnostic]` attribute namespace.

Fixes rust-lang#122446
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@compiler-errors compiler-errors

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.78.0

Development

Successfully merging this pull request may close these issues.

diagnostic_namespace was not listed in declare_features ICE

5 participants

@weiznich @rustbot @compiler-errors @bors @TaKO8Ki